Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPMI replays missing on arm32 for CORINFO_OBJECT_HANDLE JIT-EE APIs #104329

Closed
jakobbotsch opened this issue Jul 2, 2024 · 2 comments · Fixed by #112617
Closed

SPMI replays missing on arm32 for CORINFO_OBJECT_HANDLE JIT-EE APIs #104329

jakobbotsch opened this issue Jul 2, 2024 · 2 comments · Fixed by #112617
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Milestone
10.0.0

Comments

@jakobbotsch
Copy link
Member

The arm32 SPMI replay frequently has a very large miss rate compared to others. I was looking at a log today and noticed that it is mostly coming from GetObjectType and IsObjectImmutable. It looks like something related to sign vs zero extensions of the handles:

[20:38:26] MISSING: Method context 36804 failed to replay: SuperPMI assertion failed (missing key "key" in map IsObjectImmutable): key FFFFFFFFEE3A7040
[20:38:26] MISSING: Method context 36976 failed to replay: SuperPMI assertion failed (missing key "key" in map GetObjectType): key FFFFFFFFEE6A5264

cc @dotnet/jit-contrib @EgorBo
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 2, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@EgorBo EgorBo self-assigned this Jul 2, 2024
@EgorBo EgorBo mentioned this issue Jul 3, 2024
Closed
@EgorBo EgorBo added this to the 9.0.0 milestone Jul 3, 2024
@EgorBo EgorBo removed the untriaged New issue has not been triaged by the area owner label Jul 3, 2024
@EgorBo
Copy link
Member

EgorBo commented Aug 1, 2024

Moving to 10.0 since it's not clear whether this is a correctness issue or not

@EgorBo EgorBo modified the milestones: 9.0.0, 10.0.0 Aug 1, 2024
@jakobbotsch jakobbotsch mentioned this issue Feb 16, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Feb 16, 2025
@jakobbotsch jakobbotsch mentioned this issue Feb 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
10.0.0
2 participants
@EgorBo @jakobbotsch