-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][Perf] Reflection.Invoke
and Enum.Parse_Flags
Regressions on 4/11/2024 11:29:08 PM
#104777
Comments
Tracked at #101134 |
Tagging subscribers to this area: @directhex, @matouskozak |
Tagging subscribers to this area: @dotnet/area-system-runtime |
Tagging subscribers to this area: @dotnet/area-system-reflection |
@jkoritzinsky are you still looking at a fix here? |
Yeah I'm still looking at this. Haven't made much progress though as I'm having trouble getting a perf-testing harness running locally to investigate. |
For MonoAOT benchmarks, the benchmark_local script is my prefered way of testing PRs. Let me know if you need help with running that locally. |
Tagging subscribers to this area: @dotnet/area-system-runtime |
Reflection.Invoke
and Enum.Parse_Flags
Regressions on 4/11/2024 11:29:08 PM
@jkoritzinsky -- Checking in to see if this is still on your radar for .NET 9. At this point, it's unlikely we would take any changes unless it was clearly understood and low risk, but before GA code-complete, it would be good to know the assessment and determine if we want to accept the regression or keep this open. Thanks. |
Closing this out as an acceptable regression given the code maintainability improvements. |
Run Information
Regressions in System.Tests.Perf_Enum
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Repro Steps
Prerequisites (Files either built locally (with build.(sh/cmd) or downloaded from payload above (if same system setup) (in this order))
runtime/artifacts
or build instructions: Libraries README args:-subset libs+libs.tests -rc release -configuration Release -arch $RunArch -framework net8.0
runtime/artifacts/bin/coreclr/$RunOS.$RunArch.Release
, build instructions: CoreCLR README args:-subset clr+libs -rc release -configuration Release -arch $RunArch -framework net8.0
runtime/artifacts/bin/mono/$RunOS.$RunArch.Release
, build instructions: MONO README args:-arch $RunArch -os $RunOS -s mono+libs+host+packs -c Release /p:CrossBuild=false /p:MonoLLVMUseCxx11Abi=false
Linux
Windows
System.Tests.Perf_Enum.Parse_Flags(text: "Red, Orange, Yellow, Green, Blue")
ETL Files
Histogram
JIT Disasms
System.Tests.Perf_Enum.Parse_Flags(text: "Red")
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Reflection.Invoke
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Repro Steps
Prerequisites (Files either built locally (with build.(sh/cmd) or downloaded from payload above (if same system setup) (in this order))
runtime/artifacts
or build instructions: Libraries README args:-subset libs+libs.tests -rc release -configuration Release -arch $RunArch -framework net8.0
runtime/artifacts/bin/coreclr/$RunOS.$RunArch.Release
, build instructions: CoreCLR README args:-subset clr+libs -rc release -configuration Release -arch $RunArch -framework net8.0
runtime/artifacts/bin/mono/$RunOS.$RunArch.Release
, build instructions: MONO README args:-arch $RunArch -os $RunOS -s mono+libs+host+packs -c Release /p:CrossBuild=false /p:MonoLLVMUseCxx11Abi=false
Linux
Windows
System.Reflection.Invoke.StaticMethod5_ByRefParams_int_string_struct_class_bool
ETL Files
Histogram
JIT Disasms
System.Reflection.Invoke.StaticMethod4_ByRefParams_int_string_struct_class
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: