Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Trigger relink on EmccMaximumHeapSize change #104790

Closed
ilonatommy opened this issue Jul 12, 2024 · 4 comments · Fixed by #105027
Closed

[browser] Trigger relink on EmccMaximumHeapSize change #104790

ilonatommy opened this issue Jul 12, 2024 · 4 comments · Fixed by #105027
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Milestone

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Jul 12, 2024

Expectations:

  • EmccMaxHeapSize is set -> relink
  • If there's no workload -> fail

Use WBT added in #104662.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jul 12, 2024
@ilonatommy ilonatommy added this to the 9.0.0 milestone Jul 12, 2024
@ilonatommy ilonatommy self-assigned this Jul 12, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@maraf
Copy link
Member

maraf commented Jul 14, 2024

Shouldn't we think more broadly? We have plenty of properties and items that modify native build and that don't trigger it.

@ilonatommy
Copy link
Member Author

ilonatommy commented Jul 17, 2024

Shouldn't we think more broadly? We have plenty of properties and items that modify native build and that don't trigger it.

Should we go through whole

Public properties (optional):
list and see which ones should relink and add them to props json? Or did you have different approach in mind?

@maraf
Copy link
Member

maraf commented Jul 17, 2024

Probably I guess. It's of a thing to think about. Also, items are involved as well.

  • Do we want to always set WasmNativeBuild on behalf of the user?
  • Do we want to do it only for high frequently used props & items?
  • Do we want to do it for random props & items? 🙃
  • If we don't do it for everything, we should document the behavior.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants