Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of attributes matters to the platform analyzer? #105423

Open
ericstj opened this issue Jul 24, 2024 · 3 comments
Open

Order of attributes matters to the platform analyzer? #105423

ericstj opened this issue Jul 24, 2024 · 3 comments
Assignees
@buyaa-n
Labels
area-System.Runtime bug code-analyzer Marks an issue that suggests a Roslyn analyzer
Milestone
Future

Comments

@ericstj
Copy link
Member

ericstj commented Jul 24, 2024

In #105409 @akoeplinger needed to reorder platform attributes to fix an issue. I'm surprised our analyzer depends on the ordering of attributes. It's not a common characteristic of our API for order of attributes to matter. Is this intentional @buyaa-n @jeffhandley?

Reference: dotnet/roslyn-analyzers#5266
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 24, 2024
@ericstj ericstj added code-analyzer Marks an issue that suggests a Roslyn analyzer area-System.Runtime untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 24, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

@ericstj ericstj mentioned this issue Jul 24, 2024
Merged
@jeffhandley jeffhandley added this to the Future milestone Jul 27, 2024
@jeffhandley jeffhandley added bug and removed untriaged New issue has not been triaged by the area owner labels Jul 27, 2024
@buyaa-n
Copy link
Contributor

buyaa-n commented Aug 2, 2024

In general order doesn't matter, it probably because of related platforms handling, as there is workaround @akoeplinger I assume this is not required for 9.0

@buyaa-n buyaa-n self-assigned this Aug 2, 2024
@akoeplinger
Copy link
Member

correct, this is not needed for 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buyaa-n buyaa-n

Labels
area-System.Runtime bug code-analyzer Marks an issue that suggests a Roslyn analyzer
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@jeffhandley @akoeplinger @ericstj @buyaa-n