Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] move emsdk setup from runtime to emsdk tooling #105439

Open
2 tasks
lewing opened this issue Jul 24, 2024 · 1 comment · May be fixed by #106403
Open
2 tasks

[wasm] move emsdk setup from runtime to emsdk tooling #105439

lewing opened this issue Jul 24, 2024 · 1 comment · May be fixed by #106403
Assignees
@ilonatommy
Labels
area-Build-mono in-pr There is an active PR which will close this issue when it is merged
Milestone
10.0.0

Comments

@lewing
Copy link
Member

lewing commented Jul 24, 2024 •
edited by ilonatommy
Loading

Right now src/mono/mono.proj has complicated logic to use the emsdk packages to build runtime, that setup logic should be moved to emsdk and used where do similar things (like dotnet/icu)

see #105437 for an example

  • emscripten config file
  • Linux/Windows scripts emsdk_env*
@lewing lewing added this to the 9.0.0 milestone Jul 24, 2024
@lewing lewing mentioned this issue Jul 24, 2024
Merged
This was referenced Jul 26, 2024
Closed
Closed
@ilonatommy ilonatommy self-assigned this Jul 29, 2024
@lewing lewing modified the milestones: 9.0.0, 10.0.0 Aug 14, 2024
@lewing
Copy link
Member Author

lewing commented Aug 14, 2024

tis is infrastructure and not blocking so I'm moving to 10

@ilonatommy ilonatommy linked a pull request Aug 14, 2024 that will close this issue
Open
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilonatommy ilonatommy

Labels
area-Build-mono in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
10.0.0
2 participants
@lewing @ilonatommy