Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64/Sve: Ld/St info should be added for SVE instructions #105512

Closed
kunalspathak opened this issue Jul 25, 2024 · 3 comments · Fixed by #106328
Closed

Arm64/Sve: Ld/St info should be added for SVE instructions #105512

kunalspathak opened this issue Jul 25, 2024 · 3 comments · Fixed by #106328
Assignees
@a74nh
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:3 Work that is nice to have
Milestone
9.0.0

Comments

@kunalspathak
Copy link
Member

Currently LD , ST and other information is not tagged with sve instructions and they should be tagged appropriately, so methods like emitInsIsStore(), etc. should work. This was intentionally not done at the beginning and we wanted to do this when we complete the API implementation of all of them. See #105478
@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Jul 25, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 25, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 25, 2024
@kunalspathak
Copy link
Member Author

@a74nh @SwapnilGaikwad @dotnet/arm64-contrib

@kunalspathak kunalspathak added this to the 9.0.0 milestone Jul 25, 2024
@kunalspathak kunalspathak mentioned this issue Jul 25, 2024
Merged
@kunalspathak kunalspathak added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 25, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak kunalspathak mentioned this issue Jul 26, 2024
Closed
@a74nh a74nh added the Priority:3 Work that is nice to have label Jul 30, 2024
@a74nh
Copy link
Contributor

a74nh commented Jul 30, 2024

priority:3 for RC1 snap : I don't think this breaks anything, so is ok if it gets missed.

@a74nh a74nh removed their assignment Aug 5, 2024
@a74nh a74nh self-assigned this Aug 13, 2024
@a74nh a74nh mentioned this issue Aug 13, 2024
Merged
@a74nh a74nh added the in-pr There is an active PR which will close this issue when it is merged label Aug 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@a74nh a74nh

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:3 Work that is nice to have
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

ARM-SVE: Add LD/ST info to SVE instructions #105512 a74nh/runtime
2 participants
@a74nh @kunalspathak