Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 1 Regression on 9/10/2024 12:54:19 PM #107930

Open
performanceautofiler bot opened this issue Sep 17, 2024 · 5 comments
Open

[Perf] Linux/x64: 1 Regression on 9/10/2024 12:54:19 PM #107930

performanceautofiler bot opened this issue Sep 17, 2024 · 5 comments
Labels
arch-x64 area-System.Collections os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 76dbb27608765ac75fe2a06166271520fdab85fe
Compare 636c86342a29dfa8f419414bbd4877b882198ed3
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.TryGetValueFalse<Int32, Int32>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
2.00 μs 2.25 μs 1.13 0.06 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.TryGetValueFalse&lt;Int32, Int32&gt;*'

System.Collections.TryGetValueFalse<Int32, Int32>.IDictionary(Size: 512)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Sep 17, 2024
@LoopedBard3
Copy link
Member

Seeing this only on the two x64 Linux Queues, but no clear cause in the diffs: 4ee9789...ad6c18f.

@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Sep 17, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 17, 2024
@LoopedBard3 LoopedBard3 added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Sep 17, 2024
@jeffschwMSFT
Copy link
Member

@LoopedBard3 this test looks a bit noisy. have we seen this issue persist? I agree there is no obvious change that is the cause

@LoopedBard3
Copy link
Member

The first link in the result table: "IDictionary - Duration of single invocation", links to the history for the test and is also kept up to date. There, it does appear that the bump up has persisted. At least as of 09/19.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

@jeffhandley jeffhandley added this to the 10.0.0 milestone Sep 21, 2024
@jeffhandley jeffhandley removed the untriaged New issue has not been triaged by the area owner label Sep 21, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x64 area-System.Collections os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

5 participants