Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Net.Http.Functional.Tests.TelemetryTest failing with differing string #109024

Open
tannergooding opened this issue Oct 18, 2024 · 8 comments
Open

System.Net.Http.Functional.Tests.TelemetryTest failing with differing string #109024

tannergooding opened this issue Oct 18, 2024 · 8 comments
Assignees
@ilonatommy
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue Known Build Error Use this to report build issues in the .NET Helix tab os-browser Browser variant of arch-wasm
Milestone
Future

Comments

@tannergooding
Copy link
Member

tannergooding commented Oct 18, 2024 •
edited by build-analysis bot
Loading

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=847502
Build error leg or test failing: EventSource_ExistsWithCorrectId

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": ["Expected: \"System.Net.Http\"", "Actual:   \"HttpTelemetry\""],
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=847502
Error message validated: [Expected: "System.Net.Http" Actual: "HttpTelemetry"]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/18/2024 7:25:09 PM UTC

Report

Build Definition Test Pull Request
851735 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109133
851382 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109030
852111 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109053
852178 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109152
852100 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109180
852054 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
852027 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109176
851981 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109174
851881 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108796
851872 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #106557
851653 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
851784 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109087
851775 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108999
851722 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109168
851684 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109137
851603 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108796
851574 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109159
851553 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #106557
851521 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #104637
851504 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108731
851436 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109152
851375 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109145
851368 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109149
851350 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109087
851353 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109087
851204 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109146
851129 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109144
851132 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108882
849193 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108188
849189 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108324
849817 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109079
850951 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108512
850893 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
850885 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109138
850857 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #102144
850800 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108145
850752 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109137
850551 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109130
850695 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109136
850599 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109030
850616 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109133
850612 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109132
850566 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108636
850512 dotnet/runtime System.Net.Http.Functional.Tests.TelemetryTest_Http20.EventSource_ExistsWithCorrectId #108167
850404 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108542
850381 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
850336 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109119
850259 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108748
850248 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108636
850198 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #106085
850169 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108616
850175 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109093
847502 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108945
850115 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108990
850106 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108999
850088 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108748
850076 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108636
850072 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109118
850044 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109030
849980 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109110
849973 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #106085
849895 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109108
848814 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109053
849799 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109104
849763 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
849746 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109079
849628 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #104694
849623 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #106085
849583 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109093
849557 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109087
849493 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108999
849478 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109026
849371 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108703
849336 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109030
849318 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
849233 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108167
849219 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109026
849206 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108924
849198 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108882
849201 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108806
849106 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109030
849132 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108990
849136 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109079
848695 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108876
849017 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108512
847412 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108936
848876 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108636
848698 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108703
848682 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109066
848282 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109053
848628 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
848615 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108731
848471 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
848462 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #102704
848347 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108876
848321 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #108876
848327 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
848262 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #102144
848242 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution
848237 dotnet/runtime WasmTestOnChrome-ST-System.Net.Http.Functional.Tests.WorkItemExecution #109052
Displaying 100 of 119 results

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 119
@tannergooding tannergooding added the Known Build Error Use this to report build issues in the .NET Helix tab label Oct 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 18, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@MihaZupan MihaZupan added the os-browser Browser variant of arch-wasm label Oct 21, 2024
@MihaZupan
Copy link
Member

This failure on Browser is already tracked by #71877. The test in question should already be disabled there:

runtime/src/libraries/System.Net.Http/tests/FunctionalTests/TelemetryTest.cs

Lines 24 to 31 in f87687a

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/71877", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
public void EventSource_ExistsWithCorrectId()
{
Type esType = typeof(HttpClient).Assembly.GetType("System.Net.Http.HttpTelemetry", throwOnError: true, ignoreCase: false);
Assert.NotNull(esType);
Assert.Equal("System.Net.Http", EventSource.GetName(esType));

Does WasmTestOnChrome not fall under PlatformDetection.IsBrowser?

@pavelsavara
Copy link
Member

Maybe on browser the env variable MONO_AOT_MODE is never set ?

@pavelsavara pavelsavara added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Oct 22, 2024
@lewing
Copy link
Member

lewing commented Oct 23, 2024

@ilonatommy this and #105363 are getting hit a lot. please take a look

@ilonatommy
Copy link
Member

Maybe on browser the env variable MONO_AOT_MODE is never set ?

The test is run with /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=false.

It's true that MONO_AOT_MODE is never set, because ENABLE_AOT is not defined. I guess it should be set here:

runtime/src/tasks/AotCompilerTask/MonoAOTCompiler.cs

Line 1140 in edaa25e

{{parsedAotMode switch

The tests, however fail when AOT = false, so the active issue does not prevent it. We have a detection for EAT on wasm browser, it's this property:

runtime/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

Line 288 in edaa25e

public static bool IsBuiltWithAggressiveTrimming => IsNativeAot || IsAppleMobile;

set by this stub:

runtime/src/libraries/Common/tests/TestUtilities/ILLink.Substitutions.AggressiveTrimming.xml

Line 4 in edaa25e

<method signature="System.Boolean get_IsBuiltWithAggressiveTrimming()" body="stub" value="true" />

from here:

runtime/src/libraries/Common/tests/TestUtilities/TestUtilities.csproj

Line 13 in edaa25e

<EmbeddedResource Include="$(MSBuildThisFileDirectory)ILLink.Substitutions.AggressiveTrimming.xml"

I will add appropriate blocking condition in a PR soon.

@ilonatommy ilonatommy mentioned this issue Oct 24, 2024
Merged
@ilonatommy
Copy link
Member

ilonatommy commented Oct 24, 2024 •
edited
Loading

About this part:

Maybe on browser the env variable MONO_AOT_MODE is never set ?

It's true that MONO_AOT_MODE is never set, because ENABLE_AOT is not defined.

I found where we're setting it:

runtime/src/mono/browser/build/BrowserWasmApp.targets

Line 319 in edaa25e

<_EmccCFlags Include="-DENABLE_AOT=1" Condition="'$(_WasmShouldAOT)' == 'true'" />

that triggers:

runtime/src/mono/browser/runtime/runtime.c

Lines 308 to 312 in 8e8143e

#ifdef ENABLE_AOT
monoeg_g_setenv ("MONO_AOT_MODE", "aot", 1);
// Defined in driver-gen.c
register_aot_modules ();

so the existing blocker is also fine.

@ilonatommy ilonatommy mentioned this issue Oct 24, 2024
Closed
@ilonatommy
Copy link
Member

Browser does not support diagnostics, so in the current state it's expected to trim

runtime/src/libraries/System.Net.Http/src/System/Net/Http/HttpTelemetry.cs

Line 12 in 8e8143e

[EventSource(Name = "System.Net.Http")]

This can be enabled once we have EP working on WASM browser.

@MihaZupan MihaZupan added disabled-test The test is disabled in source code against the issue and removed untriaged New issue has not been triaged by the area owner labels Oct 24, 2024
@MihaZupan MihaZupan added this to the Future milestone Oct 24, 2024
@MihaZupan MihaZupan removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilonatommy ilonatommy

Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue Known Build Error Use this to report build issues in the .NET Helix tab os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
Future
Development

No branches or pull requests
6 participants
@lewing @pavelsavara @ericstj @tannergooding @MihaZupan @ilonatommy