[Perf] Windows/x64: 4 Regressions on 1/15/2025 2:36:03 PM +00:00

[performanceautofiler]

Run Information

Name	Value
Architecture	x64
OS	Windows 10.0.22631
Queue	ViperWindows
Baseline	73bcb1d808e906808f91780aa1af23208549426f
Compare	1ce82e73932b8bc98f6395b0169c21f17f71268b
Diff	Diff
Configs	CompilationMode:tiered, RunKind:micro

Regressions in System.Text.Json.Serialization.Tests.WriteJson<SimpleStructWithProperties>

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio
SerializeToStream - Duration of single invocation 📝 - Benchmark Source ADX - Test Multi Config Graph	237.37 ns	255.82 ns	1.08	0.27	False
SerializeToStream - Duration of single invocation 📝 - Benchmark Source ADX - Test Multi Config Graph	178.89 ns	203.17 ns	1.14	0.39	False

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Json.Serialization.Tests.WriteJson<SimpleStructWithProperties>*'

System.Text.Json.Serialization.Tests.WriteJson<SimpleStructWithProperties>.SerializeToStream(Mode: Reflection)

ETL Files

Histogram

JIT Disasms

System.Text.Json.Serialization.Tests.WriteJson<SimpleStructWithProperties>.SerializeToStream(Mode: SourceGen)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

---

Run Information

Name	Value
Architecture	x64
OS	Windows 10.0.22631
Queue	ViperWindows
Baseline	73bcb1d808e906808f91780aa1af23208549426f
Compare	1ce82e73932b8bc98f6395b0169c21f17f71268b
Diff	Diff
Configs	CompilationMode:tiered, RunKind:micro

Regressions in System.Text.Json.Serialization.Tests.WriteJson<Int32>

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio
SerializeObjectProperty - Duration of single invocation 📝 - Benchmark Source ADX - Test Multi Config Graph	144.28 ns	164.30 ns	1.14	0.40	False

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Json.Serialization.Tests.WriteJson<Int32>*'

System.Text.Json.Serialization.Tests.WriteJson<Int32>.SerializeObjectProperty(Mode: Reflection)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

---

Run Information

Name	Value
Architecture	x64
OS	Windows 10.0.22631
Queue	ViperWindows
Baseline	73bcb1d808e906808f91780aa1af23208549426f
Compare	1ce82e73932b8bc98f6395b0169c21f17f71268b
Diff	Diff
Configs	CompilationMode:tiered, RunKind:micro

Regressions in System.Text.Json.Serialization.Tests.ReadJson<MyEventsListerViewModel>

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio
DeserializeFromReader - Duration of single invocation 📝 - Benchmark Source ADX - Test Multi Config Graph	204.46 μs	389.91 μs	1.91	0.32	False

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Json.Serialization.Tests.ReadJson<MyEventsListerViewModel>*'

System.Text.Json.Serialization.Tests.ReadJson<MyEventsListerViewModel>.DeserializeFromReader(Mode: SourceGen)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[DrewScoggins]

Related to #111348.

[MihaZupan]

I'm not seeing these results, could this all be noise @DrewScoggins?

For System.Text.Json.Serialization.Tests.WriteJson<SimpleStructWithProperties>

Method	Toolchain	Mode	Mean	Error	Ratio	Gen0	Allocated
SerializeToStream	main	Reflection	118.79 ns	1.749 ns	1.00	0.0129	216 B
SerializeToStream	pr	Reflection	118.01 ns	1.404 ns	0.99	0.0134	224 B
SerializeToStream	main	SourceGen	92.28 ns	1.024 ns	1.00	0.0029	48 B
SerializeToStream	pr	SourceGen	86.84 ns	0.809 ns	0.94	0.0033	56 B

(the allocaition is 8b larger for now because the buffer struct has an extra field, but we no longer clear => a small benefit on average)