Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IXmlSerializable interface: Missing nullable annotation #1238

Closed
jbe2277 opened this issue Jan 1, 2020 · 4 comments
Closed

IXmlSerializable interface: Missing nullable annotation #1238

jbe2277 opened this issue Jan 1, 2020 · 4 comments
Assignees
@StephenMolloy
Labels
area-Serialization
Milestone
5.0.0

Comments

@jbe2277
Copy link
Contributor

jbe2277 commented Jan 1, 2020

The IXmlSerializable interface is missing a nullable annotation for

XmlSchema GetSchema();    // Actual
XmlSchema? GetSchema();   // Expected

See doc: IXmlSerializable.GetSchema Method.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Serialization untriaged New issue has not been triaged by the area owner labels Jan 1, 2020
@vcsjones
Copy link
Member

vcsjones commented Jan 1, 2020 •
edited
Loading

The entire framework is in the process of being annotated. The progress is being tracked here: https://github.com/dotnet/corefx/issues/40623

It looks like System.Private.Xml hasn't been done yet.

@StephenBonikowsky
Copy link
Member

Closing, tracked by dotnet/corefx#40623

@HongGit HongGit removed the untriaged New issue has not been triaged by the area owner label Jun 25, 2020
@HongGit HongGit added this to the 5.0.0 milestone Jul 1, 2020
@danmoseley
Copy link
Member

@jeffhandley I assume not 5.0

@StephenMolloy
Copy link
Member

I believe this was addressed in #41476

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenMolloy StephenMolloy

Labels
area-Serialization
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
7 participants
@vcsjones @danmoseley @jbe2277 @StephenBonikowsky @HongGit @StephenMolloy @Dotnet-GitSync-Bot