Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert failure(PID 35825 [0x00008bf1], Thread: 35825 [0x8bf1]): Assertion failed 'addr->IsLocalAddrExpr() == nullptr' in 'C:Test64Bit(int):int' #12411

Closed
RussKeldorph opened this issue Apr 3, 2019 · 2 comments
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI bug
Milestone

Comments

@RussKeldorph
Copy link
Contributor

I found this on ARM64, but it repros all over the place. @CarolEidt I think this is caused by dotnet/coreclr#23570.

Job:
https://ci.dot.net/job/dotnet_coreclr/job/master/job/jitstress/job/arm64_cross_checked_ubuntu16.04_jitstress2_jitstressregs2_tst/157/testReport/junit/JIT_Regression/_JitBlue_DevDiv_278523_DevDiv_278523_DevDiv_278523_/_JitBlue_DevDiv_278523_DevDiv_278523_DevDiv_278523_sh/

Failed test:
JIT_Regression.JitBlue_DevDiv_278523_DevDiv_278523_DevDiv_278523._JitBlue_DevDiv_278523_DevDiv_278523_DevDiv_278523_sh

Failed log:

JIT_Regression._JitBlue_DevDiv_278523_DevDiv_278523_DevDiv_278523_._JitBlue_DevDiv_278523_DevDiv_278523_DevDiv_278523_sh [FAIL]
        
        Assert failure(PID 35825 [0x00008bf1], Thread: 35825 [0x8bf1]): Assertion failed 'addr->IsLocalAddrExpr() == nullptr' in 'C:Test64Bit(int):int' (IL size 41)
        
            File: /mnt/j/workspace/dotnet_coreclr/master/arm64_cross_checked_ubuntu16.04/src/jit/importer.cpp Line: 10766
            Image: /home/robox/j/workspace/dotnet_coreclr/master/jitstress/arm64_cross_checked_ubuntu16.04_jitstress2_jitstressregs2_tst/bin/tests/Linux.arm64.Checked/Tests/Core_Root/corerun
        
        /home/robox/j/workspace/dotnet_coreclr/master/jitstress/arm64_cross_checked_ubuntu16.04_jitstress2_jitstressregs2_tst/bin/tests/Linux.arm64.Checked/JIT/Regression/JitBlue/DevDiv_278523/DevDiv_278523/DevDiv_278523.sh: line 252: 35825 Aborted                 (core dumped) $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"
        /n/nReturn code:      1/nRaw output file:      /home/robox/j/workspace/dotnet_coreclr/master/jitstress/arm64_cross_checked_ubuntu16.04_jitstress2_jitstressregs2_tst/bin/tests/Linux.arm64.Checked/JIT/Regression/Reports/JIT.Regression/JitBlue/DevDiv_278523/DevDiv_278523/DevDiv_278523.output.txt/nRaw output:/nBEGIN EXECUTION
        /home/robox/j/workspace/dotnet_coreclr/master/jitstress/arm64_cross_checked_ubuntu16.04_jitstress2_jitstressregs2_tst/bin/tests/Linux.arm64.Checked/Tests/Core_Root/corerun DevDiv_278523.exe ''
        Expected: 100
        Actual: 134
        END EXECUTION - FAILED
        Test Harness Exitcode is : 1
        /nTo run the test:/n> set CORE_ROOT=/home/robox/j/workspace/dotnet_coreclr/master/jitstress/arm64_cross_checked_ubuntu16.04_jitstress2_jitstressregs2_tst/bin/tests/Linux.arm64.Checked/Tests/Core_Root/n> /home/robox/j/workspace/dotnet_coreclr/master/jitstress/arm64_cross_checked_ubuntu16.04_jitstress2_jitstressregs2_tst/bin/tests/Linux.arm64.Checked/JIT/Regression/JitBlue/DevDiv_278523/DevDiv_278523/DevDiv_278523.sh/n
        Expected: True
        Actual:   False
        Stack Trace:
          /mnt/j/workspace/dotnet_coreclr/master/arm64_cross_checked_ubuntu16.04/bin/tests/Linux.arm64.Checked/TestWrappers/JIT.Regression/JIT.Regression.XUnitWrapper.cs(68709,0): at JIT_Regression._JitBlue_DevDiv_278523_DevDiv_278523_DevDiv_278523_._JitBlue_DevDiv_278523_DevDiv_278523_DevDiv_278523_sh()
@RussKeldorph
Copy link
Contributor Author

@dotnet/jit-contrib

CarolEidt referenced this issue in CarolEidt/coreclr Apr 3, 2019
The assert introduced in dotnet#23570 was overly aggressive, and didn't account for the fact that pointer arithmetic can exist in the IL, not just introduced by morph.

Fix #23693
CarolEidt referenced this issue in dotnet/coreclr Apr 4, 2019
The assert introduced in #23570 was overly aggressive, and didn't account for the fact that pointer arithmetic can exist in the IL, not just introduced by morph.

Fix #23693
@sandreenko
Copy link
Contributor

@briansull I think it can fix some asserts that we hit in DevDiv_837706

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI bug
Projects
None yet
Development

No branches or pull requests

4 participants