Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows|Arm32] Native varargs unsupported by the platform #12979

Closed
jashook opened this issue Jun 26, 2019 · 9 comments
Closed

[Windows|Arm32] Native varargs unsupported by the platform #12979

jashook opened this issue Jun 26, 2019 · 9 comments
Labels
arch-arm32 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitUntriaged CLR JIT issues needing additional triage os-windows
Milestone
Future

Comments

@jashook
Copy link
Contributor

jashook commented Jun 26, 2019

This is an issue to track specifically arm32 Windows not supporting native varargs __arglist and Pinvokes to va_list functions.

See https://github.com/dotnet/coreclr/issues/18377 for information regarding the codegen bring-up on the platform.

category:reach
theme:varargs
skill-level:expert
cost:medium
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@jkotas
Copy link
Member

jkotas commented Nov 22, 2020

Windows Arm32 is no longer supported.

@jkotas jkotas closed this as completed Nov 22, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2020
@BrianBohe
Copy link
Member

BrianBohe commented Feb 22, 2023 •
edited
Loading

@jkotas Test src/tests/JIT/Directed/PREFIX/unaligned/1/arglist_Target_ARM.ilproj is disabled but after merging JIT\Directed, the ilproj filename changed got scheduled and is actually passing. I guess we should either remove the test or enable it back. What is the policy here?

@BrianBohe BrianBohe reopened this Feb 22, 2023
@BrianBohe
Copy link
Member

Same with JIT/Directed/PREFIX/unaligned/4/arglist_Target_ARM

@BrianBohe
Copy link
Member

Again here

@BrianBohe
Copy link
Member

I am not sure whether this one is related also, but was skip for windows and non-windows (its analogous target TargetUnix)

@jkotas
Copy link
Member

jkotas commented Feb 23, 2023

What is the policy here?

vararg tests should be running on Windows CoreCLR only. vararg tests should be disabled for NativeAOT, Mono and all non-Windows platforms.

@BrianBohe
Copy link
Member

@jkotas Should we leave the test for non-windows as disabled in case this change in the future then?

@jkotas
Copy link
Member

jkotas commented Feb 24, 2023

Yes, these tests should remain disabled for non-Windows.

@BrianBohe
Copy link
Member

Thanks @jkotas !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-arm32 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitUntriaged CLR JIT issues needing additional triage os-windows
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@jashook @jkotas @msftgits @BrianBohe @BruceForstall