Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate rel OSX ZipFile failures #1551

Closed
ianhays opened this issue Aug 21, 2017 · 1 comment · Fixed by #1728
Closed

Investigate rel OSX ZipFile failures #1551

ianhays opened this issue Aug 21, 2017 · 1 comment · Fixed by #1728
Assignees
@wfurt
Labels
area-System.IO.Compression disabled-test The test is disabled in source code against the issue os-mac-os-x macOS aka OSX test-bug Problem in test source code (most likely)
Milestone
5.0.0

Comments

@ianhays
Copy link
Contributor

ianhays commented Aug 21, 2017

Some ZipFile tests are failing on OSX in rel/1.0.0 and rel/1.1.0 because they're unable to match file names to entries in the FileData class. We need to investigate why they're only failing on rel e.g. if they're missing some recent test fixes and determine if there is something more insidious happening.

PR's to disable the tests temporarily:
dotnet/corefx#23346
dotnet/corefx#23359
@ianhays ianhays assigned ianhays and unassigned ianhays Aug 21, 2017
@carlossanlop
Copy link
Member

carlossanlop commented Dec 18, 2019 •
edited
Loading

Triage:
Double check if the tests are still failing in master and get them fixed.
Note: Original issue was affecting 1.0 and 1.1 which are not supported anymore.

@carlossanlop carlossanlop transferred this issue from dotnet/corefx Jan 9, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.IO.Compression untriaged New issue has not been triaged by the area owner labels Jan 9, 2020
@carlossanlop carlossanlop added disabled-test The test is disabled in source code against the issue os-mac-os-x macOS aka OSX test-bug Problem in test source code (most likely) and removed untriaged New issue has not been triaged by the area owner labels Jan 9, 2020
@carlossanlop carlossanlop added this to the 5.0 milestone Jan 9, 2020
@wfurt wfurt mentioned this issue Jan 14, 2020
Merged
@wfurt wfurt self-assigned this Jan 14, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wfurt wfurt

Labels
area-System.IO.Compression disabled-test The test is disabled in source code against the issue os-mac-os-x macOS aka OSX test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

enable zip unicode tests on OSX wfurt/runtime
4 participants
@carlossanlop @ianhays @wfurt @Dotnet-GitSync-Bot