Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP2: Support Huffman encoding for sending headers #1590

Closed
geoffkizer opened this issue Jul 24, 2018 · 2 comments
Closed

HTTP2: Support Huffman encoding for sending headers #1590

geoffkizer opened this issue Jul 24, 2018 · 2 comments
Assignees
@scalablecory
Labels
area-System.Net.Http enhancement Product code improvement that does NOT require public API changes/additions
Milestone
5.0.0

Comments

@geoffkizer
Copy link
Contributor

HPACK defines a fixed Huffman encoding for header strings. We should consider implementing this and using it. It's a lesser priority than using the static table, however (#31307).
@Tratcher
Copy link
Member

Yes, this should be a straight forward perf item. This will also be shared with Kestrel (not implemented there yet either?).

@scalablecory scalablecory self-assigned this Sep 24, 2019
scalablecory referenced this issue in scalablecory/corefx Oct 15, 2019
Add Huffman encoding for HTTP2 headers. Resolves #31308
e1de039
scalablecory referenced this issue in scalablecory/corefx Oct 15, 2019
Add Huffman encoding for HTTP2 headers. Resolves #31308
5c02442
@scalablecory
Copy link
Contributor

Prototype indicates this has a negative perf impact and the benefit is not clear. I'll keep my code around for future reference, but am closing this issue for now -- we can revisit if we find a clear benefit later.

@danmoseley danmoseley transferred this issue from dotnet/corefx Jan 9, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Net.Http untriaged New issue has not been triaged by the area owner labels Jan 9, 2020
@danmoseley danmoseley added the enhancement Product code improvement that does NOT require public API changes/additions label Jan 9, 2020
@karelz karelz added this to the 5.0 milestone Apr 15, 2020
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Apr 15, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@scalablecory scalablecory

Labels
area-System.Net.Http enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

HTTP2: Huffman encoding for headers. scalablecory/corefx
6 participants
@Tratcher @scalablecory @karelz @danmoseley @geoffkizer @Dotnet-GitSync-Bot