Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plan for Digit separators in corefx #19641

Closed
tanaka-takayoshi opened this issue Dec 10, 2016 · 4 comments
Closed

Support plan for Digit separators in corefx #19641

tanaka-takayoshi opened this issue Dec 10, 2016 · 4 comments
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Runtime help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@tanaka-takayoshi
Copy link

Related to the roslyn issue dotnet/roslyn#216, do you have any plan to support Digit separators in int.Parse, Conver.ToInt32, and other methods?

@karelz
Copy link
Member

karelz commented Dec 12, 2016

No plans at this moment. Do you have a proposal?
Is the Rolsyn change done deal? Which version will it be implemented in?

@AlexGhiondea
Copy link
Contributor

It looks like we would need a formal API proposal for this.

@tanaka-takayoshi
Copy link
Author

At present, It is only necessary for me to confirm there're no plans to support this.

//will be supported by Roslyn
var int i = 1234_5678;
var long l = 0x_dead_beaf;

//no plans to support?
Convert.ToInt32("1234_5678");
Convert.ToInt32("0xdead_beaf");

However, I'd like to hear other opinions.

@AlexGhiondea
Copy link
Contributor

@tanaka-takayoshi as @karelz mentioned, we currently don't have any plans to support this.

We would like to consider this, but we would also want to make sure we follow the same pattern Roslyn is using.

Is this something you would be interested in pursuing?

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Runtime help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

5 participants