Tests in System.Data.Common crash on uapaot

[alexperovich]

The following tests crash on uapaot:

• System.Data.Tests.SqlTypes.SqlXmlTest.Constructor2_Stream_Unicode
• System.Data.Tests.SqlTypes.SqlXmlTest.Constructor2_Stream_Empty
• System.Data.Tests.SqlTypes.SqlXmlTest.Constructor3
• System.Data.Tests.SqlTypes.SqlXmlTest.Constructor3_XmlReader_Empty
• System.Data.Tests.SqlTypes.SqlXmlTest.CreateReader_Stream_Unicode
• System.Data.Tests.SqlTypes.SqlXmlTest.SqlXml_fromXmlReader_CreateReaderTest
• System.Data.Tests.SqlTypes.SqlXmlTest.SqlXml_fromZeroLengthStream_CreateReaderTest
• System.Data.Tests.SqlTypes.SqlXmlTest.SqlXml_fromZeroLengthXmlReader_CreateReaderTest_withFragment

[sjoerdverweij]

I can fix SqlDateTimeTest (not a contributor yet)

[danmoseley]

@sjoerdverweij missed your post. That would be welcome except there is no way for ocmmunity folk to run uapaot tests... perhaps you'd like to make a different contribution?

[saurabh500]

These tests still fail while running with TargetGroup=uapaot

[saurabh500]

So far we have the following findings:

1. The Internal method XmlReader.CreateSqlReader cannot be accessed without modifying the rd.xml file.
   The modifications suggested are

<Assembly Name="System.Private.Xml">
      <Namespace Name="System.Xml">
        <!-- XmlQualifiedName is well known to the serializers and must not be explicitly specified to sg.exe -->
        <Type Name="XmlQualifiedName" DataContractSerializer="Excluded" DataContractJsonSerializer="Excluded"/>               
                <Type Name="XmlReader" Dynamic="Required" />
      </Namespace>

Add this to System.Private.Xml.csproj
<BlockReflectionAttribute>false</BlockReflectionAttribute>

2. Make the method public and make System.Data.Common depend on System.Private.Xml to access the public method instead of accessing the method via reflection.

[safern]

@saurabh500 could you please take a look and fix this?

[saurabh500]

@safern are you talking about reverting the PR which enable this test or a real fix?
I am working with different folks to get a fix in.

I am stuck at figuring out how to make System.Data.COmmon build with System.Private.Xml instead of the System.Xml.ReaderWriter. Any clues?

[safern]

I'm talking about a real fix. Will not revert the PR as the DateTimeTest seems to be fixed. I'm just confirming locally.

I am stuck at figuring out how to make System.Data.COmmon build with System.Private.Xml instead of the System.Xml.ReaderWriter. Any clues?

Not that come to my mind now but @joperezr might know.

[safern]

System.Data.Tests.SqlTypes.SqlDateTimeTest.GetTypeTest is indeed fixed. I don't see it failing anymore. Updating the issue description

[saurabh500]

A little context here : I have already tried using ProjectReference to include the System.Private.Xml.csproj in the System.Data.Common.csproj (after removing the System.Xml.ReaderWriter) dependency. However I get compilation errors for all the Xml namespaces.
This specifically needs to be done for 'uapaot'

[joperezr]

I am stuck at figuring out how to make System.Data.COmmon build with System.Private.Xml instead of the System.Xml.ReaderWriter

Well, System.Xml.ReaderWriter is a contract assembly and System.Private.Xml is the implementation of that contract. Do you need an internal type or something that only exists at runtime for this? If so, you basically have to move all of your dependencies to be implementation assemblies instead. For an example of this, you can take a look at the implementation project of System.Collections, which builds against implementations instead of contracts. I can help you accomplish this offline if you'd like.

[saurabh500]

@joperezr I need to change System.Private.Xml to expose an internal function for uapaot. That's why I need to change this dependency to compile System.Data.Common against System.Private.Xml.csproj

I don't think I need to change all my dependencies to implementation. I could verify it by adding

<ItemGroup>
    <ProjectReference Include="..\..\System.Private.Xml\src\System.Private.Xml.csproj" />
  </ItemGroup>

and compiling with msbuild /p:TargetGroup=uapaot

However the problems arise when I use a Condition on the above ItemGroup

<ItemGroup Condition="'$(TargetGroup)' == 'uapaot' and '$(TargetGroup)' != 'netfx'">
    <ProjectReference Include="..\..\System.Private.Xml\src\System.Private.Xml.csproj" />
  </ItemGroup>

Msbuild /v:d /p:TargetGroup=uapaot shows the TG being set to uap instead of uapaot
As a result, the csproj is not referenced. What else do I need to change to make sure that System.Data.Common can have a target group of uapaot instead of a fallback to uap?

[saurabh500]

The plan is to make the changes so that they are specific only to uapaot.

[joperezr]

I believe that you have fixed this by looking at the email thread we have going on, but let me know if I can be of any help in here.

[safern]

@saurabh500 you closed this from your PR but I didn't see that you re-enabled the tests in your PR. Could you please re-enabled them?

[saurabh500]

Ah ok. I was working with a fork before you disabled the tests again. So in my workspace I always had the tests enabled. I should have rebased.
PR at dotnet/corefx#22111