Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override new Span/Buffer-based APIs on NegotiateStream #22835

Closed
stephentoub opened this issue Jul 18, 2017 · 1 comment
Closed

Override new Span/Buffer-based APIs on NegotiateStream #22835

stephentoub opened this issue Jul 18, 2017 · 1 comment
Labels
api-approved API was approved in API review, it can be implemented area-System.Net.Security tenet-performance Performance related issue
Milestone
2.1.0

Comments

@stephentoub
Copy link
Member

Dependent on #22820.
@stephentoub
Copy link
Member Author

The default base implementations of these new virtuals will just delegate to the existing implementations, we already don't even override the existing Read/WriteAsync methods on NegotiateStream, and refactoring the implementation to better support Span/Memory is a non-trivial amount of work. If/when we decide to reinvest in further improving NegotiateStream, this work could be done, but for now it's not worthwhile to do or track. Closing.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api-approved API was approved in API review, it can be implemented area-System.Net.Security tenet-performance Performance related issue
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@stephentoub @msftgits