Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET 5 Unicode data to version 13.0.0 #2378

Closed
GrabYourPitchforks opened this issue Jan 30, 2020 · 0 comments · Fixed by #33538
Closed

Update .NET 5 Unicode data to version 13.0.0 #2378

GrabYourPitchforks opened this issue Jan 30, 2020 · 0 comments · Fixed by #33538
Assignees
Milestone

Comments

@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Jan 30, 2020

The Unicode Standard version 13.0.0 will be released on March 10, 2020. As per usual, since the .NET runtime carries a copy of Unicode-derived data, we should update our data files to match version 13.0.0 when it's released.

This will affect the following APIs:

  • System.Globalization.StringInfo
  • System.Globalization.CharUnicodeInfo
  • System.Text.Encodings.Web.*
  • System.Text.Json.* (since it depends on System.Text.Encodings.Web)

For instructions on how to update the runtime-carried Unicode data files, consult the GenUnicodeInfo docs and the STEW docs. Also update the UnicodeUcdVersion data throughout our .csproj files (see samples).

From a cursory reading of the changes to Unicode 13.0.0 I don't believe this will result in any of our tools introducing new API surface to the System.Text.Unicode.UnicodeRanges static type.

For reference, as of this writing our derived data is based on Unicode 12.1.0.

Edit: UAX#29 was also updated as part of the Unicode 13.0.0 wave. However, the changes that are relevant to us are wholly encapsulated within the data files. The core grapheme cluster break algorithm (Sec. 3.1.1) was not changed. So we don't need to make any code changes to TextSegmentationUtility.

@GrabYourPitchforks GrabYourPitchforks added this to the 5.0 milestone Jan 30, 2020
@GrabYourPitchforks GrabYourPitchforks self-assigned this Jan 30, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 30, 2020
@GrabYourPitchforks GrabYourPitchforks removed untriaged New issue has not been triaged by the area owner area-System.Text.Encodings.Web labels Mar 10, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants