Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seg fault in System.Drawing.Common tests on Unix #23784

Closed
stephentoub opened this issue Oct 9, 2017 · 74 comments
Closed

Seg fault in System.Drawing.Common tests on Unix #23784

stephentoub opened this issue Oct 9, 2017 · 74 comments
Assignees
Labels
area-System.Drawing disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Milestone

Comments

@stephentoub
Copy link
Member

We've been plagued by seg faults on Linux in the System.Drawing.Common tests, e.g. this one on SUSE:
https://mc.dot.net/#/user/stephentoub/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/91ec984d64908b3ab312bef6f6fa599f5ea1cee7/workItem/System.Drawing.Common.Tests/wilogs

2017-10-09 19:45:10,371: INFO: proc(54): run_and_log_output: Output: Discovering: System.Drawing.Common.Tests
2017-10-09 19:45:12,085: INFO: proc(54): run_and_log_output: Output: Discovered:  System.Drawing.Common.Tests
2017-10-09 19:45:12,654: INFO: proc(54): run_and_log_output: Output: Starting:    System.Drawing.Common.Tests
2017-10-09 19:45:13,601: INFO: proc(54): run_and_log_output: Output:    System.Drawing.Printing.Tests.PrinterSettingsTests.MaximumCopies_ReturnsExpected [SKIP]
2017-10-09 19:45:13,601: INFO: proc(54): run_and_log_output: Output:       Condition(s) not met: \"IsAnyInstalledPrinters\"
2017-10-09 19:45:13,604: INFO: proc(54): run_and_log_output: Output:    System.Drawing.Printing.Tests.PrinterSettingsTests.LandscapeAngle_ReturnsExpected [SKIP]
2017-10-09 19:45:13,604: INFO: proc(54): run_and_log_output: Output:       Condition(s) not met: \"IsAnyInstalledPrinters\"
2017-10-09 19:45:13,606: INFO: proc(54): run_and_log_output: Output:    System.Drawing.Printing.Tests.PrinterSettingsTests.Collate_Default_ReturnsExpected [SKIP]
2017-10-09 19:45:13,606: INFO: proc(54): run_and_log_output: Output:       Condition(s) not met: \"IsAnyInstalledPrinters\"
2017-10-09 19:45:13,620: INFO: proc(54): run_and_log_output: Output:    System.Drawing.Printing.Tests.PrinterSettingsTests.IsPlotter_ReturnsExpected [SKIP]
2017-10-09 19:45:13,620: INFO: proc(54): run_and_log_output: Output:       Condition(s) not met: \"IsAnyInstalledPrinters\"
2017-10-09 19:45:13,629: INFO: proc(54): run_and_log_output: Output:    System.Drawing.Printing.Tests.PrinterSettingsTests.Static_InstalledPrinters_ReturnsExpected [SKIP]
2017-10-09 19:45:13,629: INFO: proc(54): run_and_log_output: Output:       Condition(s) not met: \"IsAnyInstalledPrinters\"
2017-10-09 19:45:14,110: INFO: proc(54): run_and_log_output: Output:    MonoTests.System.Drawing.Imaging.PngCodecTest.Bitmap2bitData [SKIP]
2017-10-09 19:45:14,110: INFO: proc(54): run_and_log_output: Output:       Condition(s) not met: \"GetRecentGdiPlusIsAvailable2\"
2017-10-09 19:45:14,110: INFO: proc(54): run_and_log_output: Output:    MonoTests.System.Drawing.Imaging.PngCodecTest.Bitmap2bitFeatures [SKIP]
2017-10-09 19:45:14,110: INFO: proc(54): run_and_log_output: Output:       Condition(s) not met: \"GetRecentGdiPlusIsAvailable2\"
2017-10-09 19:45:14,111: INFO: proc(54): run_and_log_output: Output:    MonoTests.System.Drawing.Imaging.PngCodecTest.Bitmap2bitPixels [SKIP]
2017-10-09 19:45:14,111: INFO: proc(54): run_and_log_output: Output:       Condition(s) not met: \"GetRecentGdiPlusIsAvailable2\"
2017-10-09 19:45:15,499: INFO: proc(54): run_and_log_output: Output: /home/helixbot/dotnetbuild/work/c092864f-24dd-40c6-a4ad-db55569616e0/Work/af3a10a9-a3b8-4472-893f-3ef12b40a6c4/Unzip/RunTests.sh: line 87:  4576 Segmentation fault      (core dumped) $RUNTIME_PATH/dotnet xunit.console.netcore.exe System.Drawing.Common.Tests.dll -xml testResults.xml -notrait Benchmark=true -notrait category=nonnetcoreapptests -notrait category=nonlinuxtests -notrait category=OuterLoop -notrait category=failing
2017-10-09 19:45:15,540: INFO: proc(54): run_and_log_output: Output: Trying to find crash dumps for project: System.Drawing.Common.Tests
2017-10-09 19:45:15,540: INFO: proc(54): run_and_log_output: Output: No new dump file was found in /home/helixbot/dotnetbuild/work/c092864f-24dd-40c6-a4ad-db55569616e0/Work/af3a10a9-a3b8-4472-893f-3ef12b40a6c4/Unzip
2017-10-09 19:45:15,542: INFO: proc(54): run_and_log_output: Output: ~/dotnetbuild/work/c092864f-24dd-40c6-a4ad-db55569616e0/Work/af3a10a9-a3b8-4472-893f-3ef12b40a6c4/Unzip
2017-10-09 19:45:15,543: INFO: proc(54): run_and_log_output: Output: Finished running tests. End time=19:45:15. Return value was 139
2017-10-09 19:45:15,544: INFO: proc(58): run_and_log_output: Exit Code: 139
2017-10-09 19:45:15,545: ERROR: scriptrunner(87): _main: Error: No exception thrown, but XUnit results not created
2017-10-09 19:45:15,545: ERROR: helix_test_execution(83): report_error: Error running xunit None

This has been happening frequently for months, but I can't find an existing issue for it.

@Drawaes
Copy link
Contributor

Drawaes commented Oct 9, 2017

Tonight was the night I planned to launch an issue for this. It seems a constant source of outerloop failures. And causes me untold annoyance and investigation ... :) fix or disable I say ;)

@danmoseley
Copy link
Member

Unfortunately Dumpling isn't finding dumps on SUSE. @DrewScoggins have you had a chance ot take a look?
We need a dumpling upload from another distro.

@benaadams
Copy link
Member

@danmoseley
Copy link
Member

@benaadams I do'nt think so, that's freebsd specific.

@danmoseley
Copy link
Member

@qmfrederik do you have any context on these segfaults? I'm not sure whether they're only on SUSE, but perhaps it has an outdated copy of libgdiplus (it doesn't return false from GetRecentGdiPlusIsAvailable())

/cc @safern

@qmfrederik
Copy link
Contributor

@danmosemsft I don't have any immediate context for these segfaults.

Debian Jessie ships with version 4.2 of libgdiplus which dates from December 2015. There have been a few fixes to libdiplus since.

We'll probably need to do some work to identify all the areas where the corefx CI process identifies areas of libgdiplus which are not stable, and then decide how to deal with that; a couple of options include:

  • Do nothing and let the end users discover the issues one by one
  • Fix the issues in libgdiplus, and require that you use System.Drawing.Common with a recent version of libgdiplus
  • Proactively throw PNSE's in System.Drawing.Common on Unix on areas where we know libgdiplus to be unstable.

Meanwhile, I've downloaded the dumpling but not entirely sure what I'm looking at. Is there a way to extract the managed and native stack traces from those dumpling files?

@Drawaes
Copy link
Contributor

Drawaes commented Oct 11, 2017

Is it possible to disable these tests on these platforms and tag them with this issue in the meantime then?

It sounds like a fix isn't a quick thing and they cause a lot of outerloop failures.

@qmfrederik
Copy link
Contributor

@Drawaes Part of the problem is that for tests that cause the test process to crash (e.g. segfaults), there is no clear indication in the test logs which unit test caused the segfault - so it's not easy to say which test should be disabled (other than disabling all System.Drawing.Common tests all together).

@Drawaes
Copy link
Contributor

Drawaes commented Oct 11, 2017

Process of elimination then... you are on a binary search.

Remove 1 test on 1 distro that fails a lot. See if it starts passing, Keep going until that distro either has no tests left or passes. Once it passes go back and try to add the other tests and see if it all works. :)

At least you can narrow it hopefully, and secondly everyone else doesn't have to go into every outerloop because they always fail due to System.Drawing.

@safern
Copy link
Member

safern commented Oct 11, 2017

Finally, we’ve got a dump, yay! @qmfrederik I sword of know how to open it, so I will try it in my Ubuntu box and update the thread. I think there is a doc if you want to try opening it in your end also. Let me find it an I’ll post it here.

@safern
Copy link
Member

safern commented Oct 11, 2017

From the dumpling that @danmosemsft pointed out to I got this stack trace:

00007FDBFAAAF990 00007FDC2266A868 DomainBoundILStubClass.IL_STUB_PInvoke(IntPtr, IntPtr, Int32, Int32, Int32, Int32)
00007FDBFAAAFA30 00007FDC22807339 System.Drawing.SafeNativeMethods+Gdip.GdipDrawRectangleI(IntPtr, IntPtr, Int32, Int32, Int32, Int32)
00007FDBFAAAFA80 00007FDC2280726A System.Drawing.Graphics.DrawRectangle(System.Drawing.Pen, Int32, Int32, Int32, Int32)
00007FDBFAAAFAA0 00007FDC228071EB System.Drawing.Graphics.DrawRectangle(System.Drawing.Pen, System.Drawing.Rectangle)
00007FDBFAAAFAD0 00007FDC22802807 System.Drawing.Tests.RegionTests.Complement_GraphicsPathWithMultipleRectangles_Success()

Which points us to the test that crashed and the path that it followed to cause the crash. Will go ahead and take a look at other dumps (if there are) in the other build failures to see if there is other crashing test, and then I'll disable the crashing tests.

In the meantime, @qmfrederik would you mind taking a look at why this is crashing?

Here are the docs on how to load the dump: https://github.com/dotnet/coreclr/blob/master/Documentation/building/debugging-instructions.md#debugging-core-dumps-with-lldb

Let me know if I can help you.

@Drawaes
Copy link
Contributor

Drawaes commented Oct 11, 2017

Thanks that would be awesome

@safern
Copy link
Member

safern commented Oct 11, 2017

PR to disable: dotnet/corefx#24581

In the meantime we can keep investigating and add more test to that PR if needed.

@safern
Copy link
Member

safern commented Oct 13, 2017

@DrewScoggins
Copy link
Member

Yeah, this is known. I am going to try and look at this today, it's just been a little bit of a pain getting a working Mac.

@safern
Copy link
Member

safern commented Oct 19, 2017

Another one, this time on Ubuntu:

I can't see the failure anymore as the build was reseted. I will try to find the dump in dumpling website and investigate which test is the one that crashed.

@stephentoub
Copy link
Member Author

Seg fault on macOS this time:
https://mc.dot.net/#/user/stephentoub/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/5ecea8ff47c03a073a77916a9c7d1d806f8c7ce3/workItem/System.Drawing.Common.Tests/wilogs

2017-10-25 12:12:38,619: INFO: proc(54): run_and_log_output: Output: Discovering: System.Drawing.Common.Tests
2017-10-25 12:12:39,725: INFO: proc(54): run_and_log_output: Output: Discovered:  System.Drawing.Common.Tests
2017-10-25 12:12:40,274: INFO: proc(54): run_and_log_output: Output: Starting:    System.Drawing.Common.Tests
2017-10-25 12:12:52,982: INFO: proc(54): run_and_log_output: Output: /Users/dotnet-bot/dotnetbuild/work/138d4b64-6614-4fc8-a267-c4c6a9a2ec75/Work/c008b4fc-d63f-4cd0-93ef-79211cae6e55/Unzip/RunTests.sh: line 87: 50314 Segmentation fault: 11  (core dumped) $RUNTIME_PATH/dotnet xunit.console.netcore.exe System.Drawing.Common.Tests.dll -xml testResults.xml -notrait Benchmark=true -notrait category=nonnetcoreapptests -notrait category=nonosxtests -notrait category=OuterLoop -notrait category=failing
2017-10-25 12:20:18,988: INFO: proc(54): run_and_log_output: Output: processing dump file /Users/dotnet-bot/dotnetbuild/work/138d4b64-6614-4fc8-a267-c4c6a9a2ec75/Work/c008b4fc-d63f-4cd0-93ef-79211cae6e55/Unzip/core.50314
2017-10-25 12:20:18,988: INFO: proc(54): run_and_log_output: Output: creating dumpling dump 4817c5fd9f73e06ccb36271c47d7ea217663bb43

@safern
Copy link
Member

safern commented Oct 26, 2017

Unfortunately OSX is not uploading the dumps correctly @DrewScoggins is working on fixing that, and we're still working on being able to crack open a dump in OSX :(

@danmoseley
Copy link
Member

We could add show progress which might suggest which test.

@safern
Copy link
Member

safern commented Oct 26, 2017

We could add show progress which might suggest which test.

That is true. I will go ahead and add it now.

@stephentoub stephentoub changed the title Seg fault in System.Drawing.Common tests on Linux Seg fault in System.Drawing.Common tests on Unix Oct 26, 2017
@stephentoub
Copy link
Member Author

Another macOS seg fault here:
https://mc.dot.net/#/user/Drawaes/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/01709e234375bf1aecd9d2362d4a311a8094114e/workItem/System.Drawing.Common.Tests/wilogs

2017-10-25 18:13:11,167: INFO: proc(54): run_and_log_output: Output: /Users/dotnet-bot/dotnetbuild/work/7aaadbbd-94e2-4640-bb7d-10974357aadd/Work/1127a9e5-16bd-42eb-8614-5b3e2e37f3b6/Unzip/RunTests.sh: line 87: 64997 Segmentation fault: 11  (core dumped) $RUNTIME_PATH/dotnet xunit.console.netcore.exe System.Drawing.Common.Tests.dll -xml testResults.xml -notrait Benchmark=true -notrait category=nonnetcoreapptests -notrait category=nonosxtests -notrait category=OuterLoop -notrait category=failing
2017-10-25 18:17:09,345: INFO: proc(54): run_and_log_output: Output: processing dump file /Users/dotnet-bot/dotnetbuild/work/7aaadbbd-94e2-4640-bb7d-10974357aadd/Work/1127a9e5-16bd-42eb-8614-5b3e2e37f3b6/Unzip/core.64997
2017-10-25 18:17:09,346: INFO: proc(54): run_and_log_output: Output: creating dumpling dump b31037ac8e5b535a47f36cdfc038b614cd1eb806

@safern
Copy link
Member

safern commented Nov 23, 2017

This was redhat. Maybe with this stack trace we are able to figure out what's happening, I would suspect all of them to be related to libgdiplus

@qmfrederik looks like a libgdiplus issue. Would you mind helping to investigate?

We have this stack trace from the test logs:

2017-11-20 08:48:03,671: INFO: proc(54): run_and_log_output: Output: *** glibc detected *** /home/helixbot/dotnetbuild/work/302a2ec0-46ef-4f24-854f-9a1c67c44671/Payload/dotnet: double free or corruption (fasttop): 0x00007fbf7c05ad90 ***
2017-11-20 08:48:03,672: INFO: proc(54): run_and_log_output: Output: ======= Backtrace: =========
2017-11-20 08:48:03,672: INFO: proc(54): run_and_log_output: Output: /lib64/libc.so.6(+0x75dee)[0x7fc028a99dee]
2017-11-20 08:48:03,672: INFO: proc(54): run_and_log_output: Output: /lib64/libc.so.6(+0x78c80)[0x7fc028a9cc80]
2017-11-20 08:48:03,672: INFO: proc(54): run_and_log_output: Output: /lib64/libc.so.6(+0x7bc10)[0x7fc028a9fc10]
2017-11-20 08:48:03,672: INFO: proc(54): run_and_log_output: Output: /lib64/libc.so.6(realloc+0x158)[0x7fc028a9ff08]
2017-11-20 08:48:03,673: INFO: proc(54): run_and_log_output: Output: /lib64/libglib-2.0.so.0(g_realloc+0x2f)[0x7fc01fba1b7f]
2017-11-20 08:48:03,673: INFO: proc(54): run_and_log_output: Output: /lib64/libglib-2.0.so.0(+0x17bcb)[0x7fc01fb6fbcb]
2017-11-20 08:48:03,673: INFO: proc(54): run_and_log_output: Output: /lib64/libglib-2.0.so.0(g_array_append_vals+0x27)[0x7fc01fb70087]
2017-11-20 08:48:03,673: INFO: proc(54): run_and_log_output: Output: /usr/lib64/libgdiplus.so.0(+0x1e342)[0x7fc01fe8d342]
2017-11-20 08:48:03,673: INFO: proc(54): run_and_log_output: Output: /usr/lib64/libgdiplus.so.0(GdipAddPathLine2+0x55)[0x7fc01fe8df65]
2017-11-20 08:48:03,673: INFO: proc(54): run_and_log_output: Output: /usr/lib64/libgdiplus.so.0(GdipCreatePathGradient+0xb7)[0x7fc01fea0e17]
2017-11-20 08:48:03,673: INFO: proc(54): run_and_log_output: Output: [0x7fbfaf22ec15]

also the logs have the memory map: https://mc.dot.net/#/product/netcore/master/source/official~2Fcorefx~2Fmaster~2F/type/test~2Ffunctional~2Fcli~2F/build/20171120.02/workItem/System.Drawing.Common.Tests/wilogs

And you can download the dump from: https://dumpling.azurewebsites.net/api/dumplings/archived/eb3711408ba3f7b1fd513e4589207c5d90f9f0d6

In order to debug the dump you can follow: https://github.com/dotnet/corefx/blob/master/Documentation/debugging/unix-instructions.md#debugging-core-dumps-with-lldb

cc: @danmosemsft

@qmfrederik
Copy link
Contributor

@safern Is there a way we can get the latest version of libgdiplus (as in, the git version) on the CI servers? @hughbe has been doing a lot of work on libgdiplus, so just upgrading may already improve the CI stability.

@safern
Copy link
Member

safern commented Nov 28, 2017

@mmitche could you help me update the installed version of libgdiplus in CI and Helix machines?

@mmitche
Copy link
Member

mmitche commented Nov 28, 2017

@safern This is just a build time dependency that needs updating?

@filipnavara
Copy link
Member

@qmfrederik is right. The crash looks like an ancient version of libgdiplus. The Mono CI machines run on version 6.0.4 right now.

@ViktorHofer
Copy link
Member

Just to make sure, are you commenting on the my last post that lists a macOS crash or the post before which is about Linux-Release-SLES?

In the past, we had a possibility of using versions of libgdiplus which shipped in NuGet packages. Do you think it makes sense to use that approach for the build servers? It would make it much easier to fix something in libgdiplus, create a NuGet package which contains an updated version of libgdiplus, and use that updated version in corefx, without having to ask the infra team to do work.

YES, that would save us and the infra team a lot of trouble.

@ViktorHofer
Copy link
Member

Newer versions of libgdiplus expose version information. (See mono/libgdiplus#84). Do you think it would make sense to have System.Drawing check for this version, and throw an exception of a too old version of libgdiplus is installed?

Yes, that would be good. We could check for a minimum installed version. Do you mind submitting a PR for that?

This makes me wonder - would it be worth writing some documentation recommending folks to use a recent version of libgdiplus (perhaps by pointing them to the Mono package repository)?

cc @richlander for the libgdiplus documentation question.

@filipnavara
Copy link
Member

The Linux-Release-SLES is ancient libgdiplus for sure. Haven't looked at the macOS crash yet.

@qmfrederik
Copy link
Contributor

Yes, that would be good. We could check for a minimum installed version. Do you mind submitting a PR for that?

Let me give that a try. I'll also check whether the libgdiplus-from-NuGet approach still works. May take a couple of days. Ping me if I haven't got round to doing it by next week 😄. If someone else can do it faster, feel free to do so 😄 .

@ViktorHofer
Copy link
Member

@jkotas unsure if this issue was only tracking rhel6 failures.

@jkotas
Copy link
Member

jkotas commented Jan 13, 2020

Keeping it open. There are still tests disabled against this issue.

@jkotas jkotas reopened this Jan 13, 2020
@safern safern reopened this Jan 13, 2020
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@am11
Copy link
Member

am11 commented Mar 29, 2020

Failed again on macOS.

PR: #34263
log: https://helix.dot.net/api/2019-06-17/jobs/74948d67-efe9-45ac-bb09-db4dbeea86e3/workitems/System.Drawing.Common.Tests/console
core dump: https://helix.dot.net/api/2019-06-17/jobs/74948d67-efe9-45ac-bb09-db4dbeea86e3/workitems/System.Drawing.Common.Tests/files/core.88162

  Starting:    System.Drawing.Common.Tests (parallel test collections = on, max threads = 12)
    System.Drawing.Printing.Tests.PrinterSettingsTests.IsPlotter_ReturnsExpected [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
    System.Drawing.Printing.Tests.PrinterSettingsTests.Collate_Default_ReturnsExpected [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
    System.Drawing.Printing.Tests.PrinterSettingsTests.Clone_Success [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
    System.Drawing.Printing.Tests.PrinterSettingsTests.MaximumCopies_ReturnsExpected [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
    System.Drawing.Printing.Tests.PrinterSettingsTests.Static_InstalledPrinters_ReturnsExpected [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
    System.Drawing.Printing.Tests.PrinterSettingsTests.LandscapeAngle_ReturnsExpected [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
    System.Drawing.Printing.Tests.PrintControllerTests.OnStartPage_InvokeWithPrint_ReturnsNull [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
    System.Drawing.Printing.Tests.PreviewPrintControllerTests.OnStartPrint_InvokeWithDocument_Success [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
    System.Drawing.Printing.Tests.PreviewPrintControllerTests.OnStartPage_InvokeWithPrint_ReturnsNull [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
    System.Drawing.Printing.Tests.PreviewPrintControllerTests.OnStartPage_InvokeNullEventArgsPageSettings_ReturnsNull [SKIP]
      Condition(s) not met: "IsAnyInstalledPrinters"
./RunTests.sh: line 161: 88162 Segmentation fault: 11  (core dumped) "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.Drawing.Common.Tests.runtimeconfig.json --depsfile System.Drawing.Common.Tests.deps.json xunit.console.dll System.Drawing.Common.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing -notrait category=nonnetcoreapptests -notrait category=nonosxtests $RSP_FILE
/private/tmp/helix/working/B4E40A4A/w/A3F20890/e
----- end Sun Mar 29 17:22:46 EDT 2020 ----- exit code 139 ----------------------------------------------------------
exit code 139 means SIGSEGV Illegal memory access. Deref invalid pointer, overrunning buffer, stack overflow etc. Core dumped.

@tarekgh tarekgh added test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs and removed untriaged New issue has not been triaged by the area owner test-bug Problem in test source code (most likely) labels Mar 29, 2020
@safern safern modified the milestones: 5.0.0, Future Jul 8, 2020
@teo-tsirpanis
Copy link
Contributor

Since #64084 got merged, System.Drawing.Common does not work anymore on Unix. This issue should be closed.

@danmoseley
Copy link
Member

Thanks @teo-tsirpanis . I wonder if there are any other active drawing issues that are unix only.

@teo-tsirpanis
Copy link
Contributor

#64084 (comment)

@safern
Copy link
Member

safern commented Feb 1, 2022

I wonder if there are any other active drawing issues that are unix only.

There are a ton. I need to go through them and close them. However I'm waiting to do so, because some might use an active issue attribute on a test referencing the issue, so I'd like to clean that up as well.

@teo-tsirpanis
Copy link
Contributor

All Unix-related ActiveIssue attributes will be removed with #64623.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Drawing disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Projects
None yet
Development

No branches or pull requests