Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply hang protection to HashSet<T> that we added to Dictionary<K,V> #25520

Closed
danmoseley opened this issue Mar 19, 2018 · 5 comments
Closed

Comments

@danmoseley
Copy link
Member

HashSet is likely prone to the same expensive hang as it uses essentially the same datastructures.

We should port dotnet/coreclr#16991 to Hashset.

cc @benaadams

@danmoseley
Copy link
Member Author

@danmoseley
Copy link
Member Author

I see @vancem pointed out it has been reported to have been hit in cloud services using HashSet also. We should certainly port, then.

@safern perhaps you'd like to do this?

@safern
Copy link
Member

safern commented Mar 19, 2018

@safern perhaps you'd like to do this?

Porting it now.

@mjsabby
Copy link
Contributor

mjsabby commented May 30, 2018

Can we also port this to 2.0?

@danmoseley
Copy link
Member Author

This is not going to meet the bar to port to 2.0 given that it will be very soon superseded by 2.1 and our support policy

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants