Remove duplicated interop structures in PlatformDetection and ones from src/common instead

[ViktorHofer]

A lot of interop structures are copied. We should instead just include these structure from the common location: dotnet/corefx#32433 (comment)

[artkpv]

Hello, I'm removing these duplicates. Did for RTL_OSVERSIONINFOEX and stopped at OpenProcessToken. Didn't find for GetCurrentApplicationUserModelId and CloseHandle. Probably to add into src\Common?
Some progress at dotnet/corefx@master...artkpv:duplicates-32438

[ViktorHofer]

Right, if we use the same interop code in multiple places that isn't yet in the shared Common folder, we should put it there.

[danmoseley]

@artkpv I sent you a collaborator link. If you accept, I can assign this issue to you. Note: being a collaborator auto subscribes to the repo, you may want to adjust that after accepting.

[artkpv]

Reporting the progress. Now I've stopped at getting SafeTokenHandle to use OpenProcessToken(..). The difficulty is that I don't understand why if I reference System.Diagnostics.Process lib with this class my CoreFx.Private.TestUtilities can not find it (error CS0246: The type or namespace name 'SafeTokenHandle' could not be found). It uses older lib in .\bin\ref\System.Diagnostics.Process\4.2.1.0\... So I'm reading (this and that) and experimenting on how to reference projects. Looks tangled so far :)

[ViktorHofer]

If you push your changes I can take a look.

EDIT: I see they are already pushed. I'll take a look later.

[ViktorHofer]

Hadn't had time to look into it. Maybe somebody else can help unblocking @artkpv.

cc @Anipik @danmosemsft)

[Anipik]

@artkpv you are getting this error because SafeTokenHandle is an internal class . which OpenProcessToken you are trying to remove ?

[artkpv]

@Anipik Yes, missed that. This is to reuse Common\src\Interop\Windows\advapi32\Interop.OpenProcessToken.cs in CoreFx.Private.TestUtilities. That's inconsistency, I image, as external method in Common uses class which is not there. So I guess solution would be to move SafeTokenHandle into Common\src\Microsoft\Win32\SafeHandles\ and use it in 3 libs (System.Diagnostics.Process, System.Security.AccessControl and the one).

Update. Seems to relate to #16030

[Anipik]

I dont see any difficulty\problem in combining SafeTokenHandle class from https://github.com/dotnet/corefx/blob/d2b05edb02129eb8aad4331feb7e5b920afbb4c5/src/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeTokenHandle.cs and https://github.com/dotnet/corefx/blob/a10890f4ffe0fadf090c922578ba0e606ebdd16c/src/System.Security.AccessControl/src/System/Security/SafeSecurityHandles.cs
You can go ahead and do it

cc @danmosemsft

[artkpv]

@Anipik It is unfinished from #16030 times.

After looking at it more, the same is here and there. Probably should be ticket for this. Below is the list of files with the same class as I see.

1. public "System.Security.Principal.Windows\src\Microsoft\Win32\SafeHandles\SafeAccessTokenHandle.cs"
   Doc: "Provides a safe handle to a Windows thread or process access token."
   Used in
   CoreFx.Private.TestUtilities (3)
   System.Diagnostics.PerformanceCounter (1)
   System.IO.Pipes.Tests (2)
   System.Net.Security (2)
   System.Security.Principal.Windows (41)
   System.Security.Principal.Windows.Tests (4)

2. internal "System.Security.AccessControl/src/System/Security/SafeSecurityHandles.cs"
   In System.Security.AccessControl (14)

3. internal "Common\src\Microsoft\Win32\SafeHandles\SafeTokenHandle.cs"
   In System.Diagnostics.Process (5)

4. public partial calss SafeProcessHandle : SafeHandleZeroOrMinusOneIsInvalid System.Diagnostics.Process\src\Microsoft\Win32\SafeHandles\SafeProcessHandle.Windows.cs
   Doc: "Provides a managed wrapper for a process handle."
   In System.Diagnostics.PerformanceCounter (12)
   System.Diagnostics.Process (65)
   System.Diagnostics.Process.Tests (7)

5. internal "System.Diagnostics.Process\src\Microsoft\Win32\SafeHandles\SafeThreadHandle.cs"
   Only in System.Diagnostics.Process (19).

And 8 versions for OpenProcessToken (https://source.dot.net/#q=OpenProcessToken)

So where what should we use? :) Probably we can use only SafeProcessHandle and SafeAccessTokenHandle as they are public. I'm going to try to do this next.

[artkpv]

@ViktorHofer I guess this issue can be closed. I'm going to make another issue for the above comment.

[ViktorHofer]

Thanks a lot!