Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SDK version entry in global.json #3071

Closed
jaredpar opened this issue Mar 9, 2018 · 4 comments
Closed

Extend SDK version entry in global.json #3071

jaredpar opened this issue Mar 9, 2018 · 4 comments
Milestone

Comments

@jaredpar
Copy link
Member

jaredpar commented Mar 9, 2018

This is a feature request. Would really like to see an extension to the global.json SDK entry that allows me to specify that the SDK must match exactly what is in global.json.

The ability to specify a sdk version in global.json is only useful if it can guarantee that I have an SDK of at least the version specified. The behavior today allows for SDKs with a lower version to be chosen even when a higher SDK is available. This means that I cannot use global.json to ensure that I'm using an sdk which has the bug fixes necessary to build my repository.

The current behavior leads to issues like #3070 which will be closed as "By Design". There are bug fixes our repository absolutely depends on. Yet even though I have specified the correct minimum SDK, and have SDKS on the machine of a higher version, dotnet inexplicably silently picks a lower one. Instead of a polite error message about missing SDKs I have to close my console window because there are so many errors that even Ctrl-C is ineffective.

I'm guessing this is a compat problem at this point. Hence I recommend extending the entry something like the following:

{
  "sdk": {
    "version": "2.1.300-preview1-008174",
    "enforceVersion": "true"
  }
}
@nguerrera
Copy link
Contributor

cc @KathleenDollard I think there's overlap with this and other things being discussed.

@nguerrera
Copy link
Contributor

I reopened #3070. My quick reading of "enforceVersion" was that it should never pick anything but exact version (this has been on the table before), but #3070 shows a case where a roll-backward occured and that shouldn't happen regardless of flags.

@vitek-karas
Copy link
Member

Proposed design which should include this feature request is discussed here: dotnet/designs#71

There's also ongoing implementation in dotnet/core-setup#6953

@nguerrera
Copy link
Contributor

Done by dotnet/core-setup#6953

@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants