Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting Pack common infrastructure #3346

Closed
dleeapho opened this issue Nov 19, 2018 · 1 comment
Closed

Targeting Pack common infrastructure #3346

dleeapho opened this issue Nov 19, 2018 · 1 comment
Milestone

Comments

@dleeapho
Copy link

[dagood] dotnet/core-setup#5085 (comment) has some thoughts on handling packs similar to runtime.<rid>.<package id> packages using the .builds infra. Fewer dirs and files that way, maybe more maintainable and easily usable in other repos. (Or replace the infra completely with something simpler.)

List of refactoring ideas from earlier PRs to improve this:

dotnet/core-setup#5114

  • Remove generatemsi.ps1 powershell scripts, use msbuild projects with shared targets.
    • Peek at wixproj, but likely stick with Execs for now.
  • Consider unifying targeting pack installer creation with targeting pack pkgproj. This could make the targeting pack creation entry point cleaner.
    • I also want to look into merging Microsoft.NETCore.App.Ref.pkgproj into Microsoft.NETCore.App.pkgproj, and using it to drive other packs (Runtime, AppHost) as well. Same goal: cleaner entry point.
  • Share WiX project files to avoid boilerplate.
  • Another thing to consider is inserting a layout phase between collecting assets and pack. That way the content of the pack can be defined by the layout instead of vice-versa.

@dagood
Copy link
Member

dagood commented Nov 6, 2019

Closing: this was made common enough that we were able to split off dotnet/windowsdesktop for 5.0. Making an improved version (to make it more reasonable to onboard new repos) is tracked at dotnet/arcade#2704.

@dagood dagood closed this as completed Nov 6, 2019
@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the Future milestone Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants