Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Memory<T> overloads for Stream.Read/WriteAsync #33790

Closed
terrajobst opened this issue Mar 19, 2020 · 2 comments · Fixed by dotnet/roslyn-analyzers#3592
Closed

Prefer Memory<T> overloads for Stream.Read/WriteAsync #33790

terrajobst opened this issue Mar 19, 2020 · 2 comments · Fixed by dotnet/roslyn-analyzers#3592
Assignees
@carlossanlop
Labels
api-approved API was approved in API review, it can be implemented area-System.IO code-analyzer Marks an issue that suggests a Roslyn analyzer code-fixer Marks an issue that suggests a Roslyn code fixer
Milestone
5.0.0

Comments

@terrajobst
Copy link
Member

Find places where await stream.Read/WriteAsync(array, offset, length, ...) are used and recommend they be replaced by calls to the overloads that take {ReadOnly}Memory<byte>, to benefit from the return type being ValueTask<int>.

Category: Performance
@terrajobst terrajobst added api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.IO code-analyzer Marks an issue that suggests a Roslyn analyzer labels Mar 19, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Mar 19, 2020
@jeffhandley jeffhandley added this to the 5.0 milestone Mar 20, 2020
@jeffhandley jeffhandley added the code-fixer Marks an issue that suggests a Roslyn code fixer label Mar 21, 2020
@jeffhandley
Copy link
Member

Estimates:

  • Analyzer: Medium
  • Fixer: Medium

@terrajobst terrajobst added api-approved API was approved in API review, it can be implemented and removed untriaged New issue has not been triaged by the area owner api-suggestion Early API idea and discussion, it is NOT ready for implementation labels Mar 21, 2020
@carlossanlop carlossanlop mentioned this issue Mar 30, 2020
Merged
@carlossanlop carlossanlop mentioned this issue Apr 14, 2020
Merged
This was referenced May 1, 2020
Merged
Closed
@carlossanlop
Copy link
Member

Merged the analyzer and the fixer. Reopening because there are still two things pending:

  • Documentation
  • Executing within dotnet/runtime.

@carlossanlop carlossanlop reopened this May 7, 2020
This was referenced May 7, 2020
Merged
Closed
@turbedi turbedi mentioned this issue May 7, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@carlossanlop carlossanlop

Labels
api-approved API was approved in API review, it can be implemented area-System.IO code-analyzer Marks an issue that suggests a Roslyn analyzer code-fixer Marks an issue that suggests a Roslyn code fixer
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fixer: Prefer Memory overloads for Stream async Read/Write methods carlossanlop/roslyn-analyzers
4 participants
@jeffhandley @carlossanlop @terrajobst @Dotnet-GitSync-Bot