Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable in tree runtime pack for all of mono #35247

Closed
3 tasks
steveisok opened this issue Apr 21, 2020 · 1 comment · Fixed by #35295
Closed
3 tasks

Enable in tree runtime pack for all of mono #35247

steveisok opened this issue Apr 21, 2020 · 1 comment · Fixed by #35295

Comments

@steveisok
Copy link
Member

steveisok commented Apr 21, 2020

After working with this in a mobile context, I can see it providing benefits to all of mono. Most notably as a replacement for our 'patch-dotnet' target.

  • Relax the check for BinPlaceTestRuntimePack to be RuntimeFlavor = 'mono'
  • For desktop, the test host needs to be generated, so ensure that's still working right (basically, you should successfully run libraries tests)
  • Validate lib-runtime-packs folder is created w/ the right contents
@ghost
Copy link

ghost commented Apr 21, 2020

Tagging subscribers to this area: @directhex
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 21, 2020
@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Apr 21, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants