Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned object heap impact on profilers #35258

Closed
davmason opened this issue Apr 21, 2020 · 5 comments
Closed

Pinned object heap impact on profilers #35258

davmason opened this issue Apr 21, 2020 · 5 comments
Assignees
@davmason
Labels
area-Diagnostics-coreclr documentation Documentation bug or enhancement, does not impact product or test code
Milestone
5.0.0

Comments

@davmason
Copy link
Member

davmason commented Apr 21, 2020 •
edited by noahfalk
Loading

Overview issue in https://github.com/dotnet/runtime/issues/35561

After #32283 we have another GC heap for pinned objects. This will require at least the addition of a new entry to COR_PRF_GC_GENERATION and might require more work. This issue is tracking the investigation of any impact on profilers.
@davmason davmason added this to the 5.0 milestone Apr 21, 2020
@davmason davmason self-assigned this Apr 21, 2020
@ghost
Copy link

ghost commented Apr 21, 2020

Tagging subscribers to this area: @tommcdon
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 21, 2020
@davmason
Copy link
Member Author

The enum value was already added, still need to investigate any remaining impact though

@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Apr 22, 2020
@tommcdon tommcdon added documentation Documentation bug or enhancement, does not impact product or test code p1 labels Apr 22, 2020
@davmason
Copy link
Member Author

After doing some investigation, there is no work needed for the profiler. It will have impact on profilers since they may not expect the new generation, but there is no runtime work necessary.

@noahfalk noahfalk reopened this Apr 28, 2020
@noahfalk
Copy link
Member

David, re-opening this issue to make sure we've also considered if testing needs to be added and if the enum has been documented?

@davmason
Copy link
Member Author

I don't believe there is any testing that needs added at this point, and the documentation is done. Closing this issue

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davmason davmason

Labels
area-Diagnostics-coreclr documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
4 participants
@noahfalk @davmason @tommcdon @Dotnet-GitSync-Bot