Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error running all library tests #35664

Closed
mrj001 opened this issue Apr 30, 2020 · 8 comments · Fixed by #35709
Closed

Error running all library tests #35664

mrj001 opened this issue Apr 30, 2020 · 8 comments · Fixed by #35709
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner

Comments

@mrj001
Copy link
Contributor

mrj001 commented Apr 30, 2020

Built as follows:

$ ./build.cmd -subset clr -c Checked
$ ./build.cmd -subset Libs+Libs.Tests -runtimeConfiguration Checked

Then I tried to run all tests from root as follows (per a comment by @ViktorHofer in Issue #34152):

$ ./build.cmd libs.tests -test -coverage -runtimeConfiguration Checked

This ended quickly in the following error:

Build FAILED.

C:\Users\mrj00\source\repos\runtime\eng\testing\coverage.targets(42,7): error MSB4184: The expression ""C:\Users\mrj00\source\repos\runtime\src\libraries".SubString(50)" cannot be evaluated. startIndex cannot be larger than length of string. (Parameter 'startIndex') [C:\Users\mrj00\source\repos\runtime\Build.proj]
0 Warning(s)
1 Error(s)

Time Elapsed 00:00:23.25
Build failed.
Some builds failed:
Configuration: Debug, Architecture: x64

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Apr 30, 2020
@ghost
Copy link

ghost commented Apr 30, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ViktorHofer
Copy link
Member

This will be fixed with #35285

@danmoseley
Copy link
Member

What command should @mrj001 use meantime?

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 30, 2020

A workaround meanwhile would be to change this line: https://github.com/dotnet/runtime/blob/master/eng/testing/coverage.targets#L21 to
<Target Name="SetupCoverageFilter" Condition="'$(MSBuildProjectFile)' != 'tests.proj'">

@mrj001
Copy link
Contributor Author

mrj001 commented May 1, 2020

@ViktorHofer
I got 256 errors all similar to this:

C:\Users\mrj00\source\repos\runtime\eng\testing\tests.targets(102,24): error MSB4113: Specified condition "'$(TargetsMobile)'" evaluates to "" instead of a boolean. [C:\Users\mrj00\source\repos\runtime\src\libraries\Common\tests\Common.Tests.csproj]

Is there an expected date for that PR to be applied?

@ViktorHofer
Copy link
Member

cc @steveisok for the broken TargetsMobile condition.

Yes, the change will be merged next Monday.

@steveisok
Copy link
Member

steveisok commented May 1, 2020

We'll have a PR up for that $(TargetsMobile) check shortly. If you need to work around it, just put '$(TargetsMobile)' == 'true' for the time being.

@steveisok
Copy link
Member

PR is up #35709

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants