-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages that reference Microsoft.Bcl.AsyncInterfaces should have explicit target reference to netstandard2.1 #35984
Comments
Tagging subscribers to this area: @safern, @ViktorHofer |
@ericstj this was marked as a 5.0 candidate pre-transfer. Not sure how you want to record that in dotnet/runtime, but I put it in the 5.0 milestone. |
That's exactly what we should do. |
The work here is to do a pass on all the Microsoft.Extensions projects and make sure they are cross-compiling for most appropriate configurations. We need to do things like:
|
cc @joperezr this might be a "while you're in there" change when you add .NETFramework TFMs to these libs. |
Describe the bug
While investigating recommended target frameworks for NuGet packages I discovered that the package
Microsoft.Extensions.Hosting.Abstractions
has a reference toMicrosoft.Bcl.AsyncInterfaces
in all versions above 3.1.0 fornetstandard2.0
target framework. This causes projects that targetsnetstandard2.1
references this package incorrectly reference this.To Reproduce
Steps to reproduce the behavior:
Microsoft.Extensions.Hosting.Abstractions
Microsoft.Bcl.AsyncInterfaces
are referenced.Expected behavior
If it is a fact that
Microsoft.Extensions.Hosting.Abstractions
needs async interfaces after 3.1.0, it must explicit add a target reference tonetstandard2.1
where this package is excluded from reference.The package
Microsoft.Extensions.Hosting
has target referencenetstandard2.1
with the removal of this reference as the only difference, so it should be the same forMicrosoft.Extensions.Hosting.Abstractions
too.I am not sure if this applies to other packages, but it is worth investigating which packages that should use
netstandard2.1
and not.. It may be more something that should be investigated as a whole, not only for the extensions project.The text was updated successfully, but these errors were encountered: