Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a CI leg for design time builds #36139

Open
Anipik opened this issue May 8, 2020 · 4 comments
Open

Adding a CI leg for design time builds #36139

Anipik opened this issue May 8, 2020 · 4 comments
Labels
area-Infrastructure-libraries backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity
Milestone

Comments

@Anipik
Copy link
Contributor

Anipik commented May 8, 2020

The design time builds are necessary part of vs experience.
They are easy to break and the breaks in design time build are difficult to catch.
It will be nice to have some kind of CI leg protection here which ensures we dont regress any design time behavior.

cc @ericstj @danmosemsft @ViktorHofer @safern

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels May 8, 2020
@ghost
Copy link

ghost commented May 8, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ViktorHofer
Copy link
Member

@davkean can you please point us to a resource that explains how to do that in CI?

@Anipik
Copy link
Contributor Author

Anipik commented May 29, 2020

We will need more protections against the the VS experience. Some of these can be easily done

  • Protection again not breaking the BuildInsideVisualStudio failures // This can be easily done by setting /p:BuildInsideVisualStudio=true
  • Adding project references to the sln files // we can ensure by writing a post compile msbuild task.
  • No tfms derive property in the first property group
  • first tfm needs to be net5.0. This is also required for the solution explorer to work properly in visual studio.
  • design Time build check in ci

Copy link
Contributor

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@dotnet-policy-service dotnet-policy-service bot added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-libraries backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity
Projects
None yet
Development

No branches or pull requests

3 participants