Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add various extension methods from Microsoft.AspNet.WebApi.Client #37055

Closed
IanKemp opened this issue May 27, 2020 · 7 comments
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@IanKemp
Copy link

IanKemp commented May 27, 2020

References:

aspnet/Mvc#1639
#16538

There is a NuGet package Microsoft.AspNet.WebApi.Client that provides a whole bunch of useful extension methods to allow you to perform various useful operations on HttpClient and HttpContent instances (HttpContent.ReadAsAsync<T>() and HttpClient.PostAsJsonAsync(string) were my personal favourites). However that package is targeted at ye olde ASP.NET Web API 2, so I don't know how optimal it is for ASP.NET Core (e.g. it has no knowledge of Span<T>) and/or how long it will continue to work with Core (especially since it was last updated over a year ago).

Would it be desirable to add these extensions to ASP.NET Core? If not, is the Microsoft.AspNet.WebApi.Client package the correct and supported way to get those extensions going forward?

@IanKemp IanKemp changed the title Add various HttpContent helper methods from Microsoft.AspNet.WebApi.Client Feature Request: Add various extension methods from Microsoft.AspNet.WebApi.Client May 27, 2020
@pranavkm pranavkm transferred this issue from dotnet/aspnetcore May 27, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Net untriaged New issue has not been triaged by the area owner labels May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@IanKemp
Copy link
Author

IanKemp commented May 27, 2020

@pranavkm I don't think this should be transferred here, the functionality I'm looking for is mostly around very web-specific stuff regarding JSON.

@pranavkm
Copy link
Contributor

@IanKemp the runtime repo is the appropriate place to discuss HttpClient extensibility. Some of your asks might have already been covered by System.Net.Http.Json that was introduced very recently: #32937 (/cc @jozkee)

@IanKemp
Copy link
Author

IanKemp commented May 27, 2020

@pranavkm thanks, did not know that. The new APIs you linked to seem like they will cover a lot of my "wants" but I feel like it would be useful to cross-check them against what was/is available in Microsoft.AspNet.WebApi.Client.

@karelz
Copy link
Member

karelz commented Jun 16, 2020

@IanKemp can you please help with the cross check? Are there specific APIs which you think are missing?

@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions needs more info and removed untriaged New issue has not been triaged by the area owner labels Jun 16, 2020
@karelz karelz added this to the Future milestone Jun 16, 2020
@karelz
Copy link
Member

karelz commented Jun 16, 2020

Triage: Does not seem to be critical for 5.0 -> Future.
Unclear if anything is needed at all.

@ghost ghost added the no-recent-activity label Dec 7, 2020
@dotnet dotnet deleted a comment Dec 7, 2020
@ghost ghost removed the no-recent-activity label Dec 7, 2020
@karelz
Copy link
Member

karelz commented Jan 15, 2021

Unclear what is needed, closing.

@karelz karelz closed this as completed Jan 15, 2021
@karelz karelz modified the milestones: Future, 6.0.0 Jan 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

4 participants