Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libldap as a dependency of the runtime-deps package #37090

Closed
MichaelSimons opened this issue May 27, 2020 · 3 comments
Closed

Add libldap as a dependency of the runtime-deps package #37090

MichaelSimons opened this issue May 27, 2020 · 3 comments
Labels
area-Setup untriaged New issue has not been triaged by the area owner

Comments

@MichaelSimons
Copy link
Member

In 5.0 a new native dependency was added on libldap. As a result, it should be added as a dependency of the runtime-deps linux packages.

Related:
#36405
#36888
#68365

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label May 27, 2020
@NikolaMilosavljevic
Copy link
Member

@joperezr, @tarekgh , should libldap be included as a runtime-deps package?

@joperezr
Copy link
Member

I'm not sure what runtime-deps package is or what libraries should go in it, but libldap is pre-installed in most Unix distros with only a few exceptions (like minimal distros, for example docker containers) but it is by default present on all of the Linux and OSX platforms that we test against. For those few places where it is not present by default, it is a requirement to install it manually but I thought that was ok given that System.DirectoryServices.Protocols is an OOB package and not part of the shared framework.

@NikolaMilosavljevic
Copy link
Member

Given that this dependency is required by an OOB package, we've decided not to add it to runtime-deps package.

We might want to create optional dependencies.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Setup untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

4 participants