Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rule CA2016 rule as a warning #38596

Closed
carlossanlop opened this issue Jun 30, 2020 · 3 comments
Closed

Enable rule CA2016 rule as a warning #38596

carlossanlop opened this issue Jun 30, 2020 · 3 comments
Assignees
@carlossanlop
Labels
area-Infrastructure enhancement Product code improvement that does NOT require public API changes/additions
Milestone
5.0.0

Comments

@carlossanlop
Copy link
Member

It was expressed in this PR the desire to make rule CA2016 a warning for all dotnet/runtime, but due to this bug in dotnet/roslyn-analyzers, that can't be done yet.

Once the roslyn-analyzers bug is fixed and the assembly with the fix is updated in the dotnet/runtime build, we can make CA2016 a warning.
@carlossanlop carlossanlop added the enhancement Product code improvement that does NOT require public API changes/additions label Jun 30, 2020
@carlossanlop carlossanlop added this to the 5.0.0 milestone Jun 30, 2020
@carlossanlop carlossanlop self-assigned this Jun 30, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 30, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@carlossanlop carlossanlop removed the untriaged New issue has not been triaged by the area owner label Jun 30, 2020
@carlossanlop carlossanlop mentioned this issue Jun 30, 2020
Merged
@ghost
Copy link

ghost commented Jun 30, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@carlossanlop
Copy link
Member Author

I was able to address this in #37607

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@carlossanlop carlossanlop

Labels
area-Infrastructure enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@carlossanlop @jeffschwMSFT @Dotnet-GitSync-Bot