Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf -19%] System.Collections.CreateAddAndRemove<Int32> (2) #39107

Closed
DrewScoggins opened this issue Jul 10, 2020 · 2 comments
Closed

[Perf -19%] System.Collections.CreateAddAndRemove<Int32> (2) #39107

DrewScoggins opened this issue Jul 10, 2020 · 2 comments
Assignees
Labels
arch-x64 area-System.Collections os-linux Linux OS (any supported distro) tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@DrewScoggins
Copy link
Member

DrewScoggins commented Jul 10, 2020

Run Information

Architecture x64
OS ubuntu 18.04
Changes diff

Regressions in System.Collections.CreateAddAndRemove

Benchmark Baseline Test Test/Base Modality Baseline Outlier
List 12.20 μs 14.24 μs 1.17 False
SortedList 75.89 μs 91.68 μs 1.21 False

Related Issue on x86 Windows

[Perf -13%] System.Collections.CreateAddAndRemove (2)

graph
graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Collections.CreateAddAndRemove<Int32>*';

Histogram

System.Collections.CreateAddAndRemove.List(Size: 512)

[10580.943 ; 11622.595) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[11622.595 ; 12410.161) | @@@@@@@@@
[12410.161 ; 12754.842) | 
[12754.842 ; 13542.407) | @@@@@@@@@@@@@@@@@@@@@@@
[13542.407 ; 14082.740) | 
[14082.740 ; 14756.791) | @@@@@@
[14756.791 ; 15544.356) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[15544.356 ; 16323.314) | @@@@@@@@@@@@@@@@@
[16323.314 ; 16859.957) | @@@

System.Collections.CreateAddAndRemove.SortedList(Size: 512)

[72393.597 ; 75678.155) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[75678.155 ; 78041.146) | @@@@@@
[78041.146 ; 81949.877) | @@@@@@
[81949.877 ; 85234.435) | @@@@@@@@@@@@@@@@
[85234.435 ; 87239.391) | @@@@@@
[87239.391 ; 90717.307) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[90717.307 ; 94001.865) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[94001.865 ; 97426.333) | @@@@@@@@@@@@

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@DrewScoggins DrewScoggins added os-linux Linux OS (any supported distro) tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark arch-x64 labels Jul 10, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Collections untriaged New issue has not been triaged by the area owner labels Jul 10, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

Tagging subscribers to this area: @eiriktsarpalis
Notify danmosemsft if you want to be subscribed.

@eiriktsarpalis eiriktsarpalis added this to the 5.0.0 milestone Jul 13, 2020
@danmoseley
Copy link
Member

Duplicate of #39112

@danmoseley danmoseley marked this as a duplicate of #39112 Aug 1, 2020
@layomia layomia removed the untriaged New issue has not been triaged by the area owner label Aug 28, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-System.Collections os-linux Linux OS (any supported distro) tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

5 participants