Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Text.Encodings.Web.dll ref api compat issue in preview 8 #39444

Closed
aik-jahoda opened this issue Jul 16, 2020 · 7 comments
Closed

System.Text.Encodings.Web.dll ref api compat issue in preview 8 #39444

aik-jahoda opened this issue Jul 16, 2020 · 7 comments
Labels
area-System.Text.Encoding untriaged New issue has not been triaged by the area owner

Comments

@aik-jahoda
Copy link
Contributor

There is System.Text.Encodings.Web.dll failure in release/5.0-preview8
The problem is visible here:
https://github.com/dotnet/runtime/pull/39434/checks?check_run_id=877743259

Error message:

MatchingRefApiCompat failed - The reference assembly doesn't match all the APIs in the implementation for 'artifacts\bin\System.Text.Encodings.Web\netcoreapp3.0-Debug\System.Text.Encodings.Web.dll'. To address either fix errors in the reference assembly (referenced as implementation in compat errors for this reverse compat check), add the issues to the baseline file 'src\libraries\System.Text.Encodings.Web\src\MatchingRefApiCompatBaseline.txt' or disable this check by setting RunMatchingRefApiCompat=false in this project.

cc: @Anipik @ericstj @GrabYourPitchforks @layomia @tarekgh

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Text.Encoding untriaged New issue has not been triaged by the area owner labels Jul 16, 2020
@ghost
Copy link

ghost commented Jul 16, 2020

Tagging subscribers to this area: @tarekgh, @krwq
Notify danmosemsft if you want to be subscribed.

@ericstj
Copy link
Member

ericstj commented Jul 16, 2020

Here's the error messages from https://dev.azure.com/dnceng/public/_build/results?buildId=733219&view=logs&j=423ae147-26a3-5a4d-a4d3-4b3fc1dd598e&t=98a4dd5a-baea-5dc4-484b-ccbd315f07c8&l=4551

error : TypesMustExist : Type 'System.Runtime.Intrinsics.Arm.AdvSimd' does not exist in the reference but it does exist in the implementation. 
error : TypesMustExist : Type 'System.Runtime.Intrinsics.Arm.ArmBase' does not exist in the reference but it does exist in the implementation. 

I believe regression was caused by #38707. @eiriktsarpalis

@aik-jahoda
Copy link
Contributor Author

For the System.Runtime.Intrinsics.Arm.AdvSimd I created an issue there: #39440.

@eiriktsarpalis
Copy link
Member

I think this might be caused by the shimmed AdvSimd APIs used for netcoreapp3.0 builds. Something is causing the USE_INTERNAL_ACCESSIBILITY constant not being defined. I'll take a look.

@aik-jahoda
Copy link
Contributor Author

I expect the fix can be as simple as in: 6be3ce7

The IsPrerelease has changed in this branch: bf35bfd

@eiriktsarpalis
Copy link
Member

Tagging @pgovind

@ericstj
Copy link
Member

ericstj commented Jul 16, 2020

@eiriktsarpalis can this be closed now?

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Encoding untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

4 participants