Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*_PROFILER_PATH should come in 32 and 64 bit flavors #4088

Closed
MattWhilden opened this issue Mar 31, 2015 · 2 comments · Fixed by dotnet/coreclr#643
Closed

*_PROFILER_PATH should come in 32 and 64 bit flavors #4088

MattWhilden opened this issue Mar 31, 2015 · 2 comments · Fixed by dotnet/coreclr#643
Assignees
Labels
help wanted [up-for-grabs] Good issue for external contributors

Comments

@MattWhilden
Copy link
Contributor

As per @sawilde over on #4033:
Do you know why *_PROFILER_PATH doesn't come in 32 and 64 bit versions - it limits this feature as the processes being profiled could be a combination of both but you can only register one.

@noahfalk
Copy link
Member

noahfalk commented Apr 1, 2015

Hi @sawilde
I certainly agree, 32 and 64 bit versions are more useful. Interestingly we made a similar change for the full CLR not long ago and Jan just integrated it.
dotnet/coreclr#607
That change only modified the environment variables for full CLR and you probably want to make a similar change to CoreCLR. We’d probably get to porting it eventually, but also happy to review a PR if you want to test a similar change yourself.

Thanks!
-Noah

@MattWhilden
Copy link
Contributor Author

@noahfalk I'm adding you as the "assignee" so that if someone picks this up they'll know who to bother about PRs and questions. Let me know if this is in error.

DickvdBrink referenced this issue in DickvdBrink/coreclr Apr 5, 2015
DickvdBrink referenced this issue in DickvdBrink/coreclr Apr 5, 2015
DickvdBrink referenced this issue in DickvdBrink/coreclr Apr 5, 2015
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants