-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify build.sh to have correct usage statement regarding AMD64/x64 BuildArch #4132
Comments
The convention: |
I don't know the rationale between the two conventions, but I did specify it was in the "build.sh" file. |
We have "AMD64" and "x64" strings all over stuff inside the company... Mostly just accidental with no real hard rules. Am I to understand the convention for unix is "amd64"? @pgavlin, care to comment? |
@MattWhilden There is no convention on unix. You'll see x86_64, amd64, and probably some other variants as well. |
Thanks for the reply @kangaroo. Given that, do we just say, "Our convention for this project is x86/x64/ARM etc" or is it better for our scripts to unify some of the various names? |
I'll give my vote for whatever convention is most common in linux at the most basic level (kernel|compiler). vs I vote "i386, x86_64, arm, arm64" if these are my only options. My preference would be x86-32, x86-64 to denote intel/amd, then for arm, arm-32, arm-64. Eventually 32-bit will become extinct and a future bit system (128) will push forth so you could drop the naming for *-32 and create *-128. |
I'll follow up with folks here and see what the consensus is. I don't know how much will actually change or if we'll just document the current state with potential followup but I'll let you know. |
I think I'm needing to reiterate the OP is about a failed build due to the incorrect parameter used per "help" usage output. "./build.sh" says to use "x64", but the build will fail at the very end. |
facepalm that's an even easier fix for now. Goes to show how easy it is to get distracted. That fix seems easy enough. |
The help text for build.sh said that you should pass "x64" as a paramter for the build architecture. However, the script was looking for amd64. Update the script to look for x64 since that's what we use everywhere else (and the behavior you got if you didn't pass an argument to this script.) Fixes #689
The help text for build.sh said that you should pass "x64" as a paramter for the build architecture. However, the script was looking for amd64. Update the script to look for x64 since that's what we use everywhere else (and the behavior you got if you didn't pass an argument to this script.) Fixes #689
"x64" -> "amd64"
Otherwise, build fails at 100% with "no rule to make target 'x64'"
./build.sh
Usage()
...
...
The text was updated successfully, but these errors were encountered: