Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address ConnectionListener.AcceptAsync nullability in tests #41523

Open
CarnaViire opened this issue Aug 28, 2020 · 1 comment
Open

Address ConnectionListener.AcceptAsync nullability in tests #41523

CarnaViire opened this issue Aug 28, 2020 · 1 comment

Comments

@CarnaViire
Copy link
Member

ConnectionListener.AcceptAsync() was allowed to return null in #41304.

There's test code here that implements this API:

public override async ValueTask<Connection> AcceptAsync(IConnectionProperties options = null, CancellationToken cancellationToken = default)

This code is used in Connection tests, possibly elsewhere.

I assume this didn't break because it's just a nullability change, but we should fix it regardless. And we should fix the behavior of the test code to return null when disposed and validate this.

@CarnaViire CarnaViire added this to the 6.0.0 milestone Aug 28, 2020
@CarnaViire CarnaViire self-assigned this Aug 28, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Aug 28, 2020
@ghost
Copy link

ghost commented Aug 28, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@CarnaViire CarnaViire removed the untriaged New issue has not been triaged by the area owner label Aug 28, 2020
@CarnaViire CarnaViire removed their assignment Aug 31, 2020
@karelz karelz modified the milestones: 6.0.0, Future May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants