Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2R covariant returns test failures #41853

Closed
BruceForstall opened this issue Sep 4, 2020 · 2 comments · Fixed by #41874
Closed

R2R covariant returns test failures #41853

BruceForstall opened this issue Sep 4, 2020 · 2 comments · Fixed by #41874
Assignees
@janvorli
Labels
area-TypeSystem-coreclr blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs
Milestone
5.0.0

Comments

@BruceForstall
Copy link
Member

R2R test failures in apparently every configuration/architecture.

    Loader\classloader\MethodImpl\CovariantReturns\UnitTest\OverrideMoreDerivedReturn\OverrideMoreDerivedReturn.cmd [FAIL]
      
      Assert failure(PID 2908 [0x00000b5c], Thread: 5808 [0x16b0]): HasStableEntryPoint()
      
      CROSSGEN! MethodTable::SetSlot + 0x116 (0x00007ff6`4c19d2ea)
      CROSSGEN! ClassLoader::ValidateMethodsWithCovariantReturnTypes + 0x650 (0x00007ff6`4c1a358c)
      CROSSGEN! PushFinalLevels + 0x23 (0x00007ff6`4c1bba67)
      CROSSGEN! ClassLoader::LoadTypeHandleForTypeKey + 0x197 (0x00007ff6`4c1b9c0f)
      CROSSGEN! ClassLoader::LoadConstructedTypeThrowing + 0x200 (0x00007ff6`4c1b8c84)
      CROSSGEN! ClassLoader::LoadGenericInstantiationThrowing + 0x1ED (0x00007ff6`4c1b8f35)
      CROSSGEN! SigPointer::GetTypeHandleThrowing + 0xB3F (0x00007ff6`4c1c8323)
      CROSSGEN! LoadTypeSpecHelper + 0xC4 (0x00007ff6`4c1ebfd4)
      CROSSGEN! Module::ExpandAll + 0x6D5 (0x00007ff6`4c1e46ed)
      CROSSGEN! CEEPreloader::Preload + 0x7A (0x00007ff6`4c173bfe)
          File: F:\workspace\_work\1\s\src\coreclr\src\vm\method.hpp Line: 248
          Image: C:\h\w\A31108E3\p\crossgen.exe

Starting with: https://dev.azure.com/dnceng/public/_build/results?buildId=797990&view=ms.vss-test-web.build-test-results-tab

Failures include:

    Loader\classloader\MethodImpl\CovariantReturns\UnitTest\OverrideMoreDerivedReturn\OverrideMoreDerivedReturn.cmd [FAIL]
    Loader\classloader\MethodImpl\CovariantReturns\UnitTest\UnitTestDelegates\UnitTestDelegates.cmd [FAIL]
    Loader\classloader\MethodImpl\CovariantReturns\UnitTest\UnitTest_GVM\UnitTest_GVM.cmd [FAIL]
    Loader\classloader\MethodImpl\CovariantReturns\Interfaces\UnitTest\UnitTest.cmd [FAIL]
    Loader\classloader\MethodImpl\CovariantReturns\UnitTest\UnitTest\UnitTest.cmd [FAIL]

Likely candidate PR: #41703

@davidwrighton @janvorli PTAL
@BruceForstall BruceForstall added area-CrossGen/NGEN-coreclr blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs labels Sep 4, 2020
@BruceForstall BruceForstall added this to the 5.0.0 milestone Sep 4, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 4, 2020
@BruceForstall
Copy link
Member Author

cc @mangod9

@BruceForstall BruceForstall mentioned this issue Sep 4, 2020
Merged
@janvorli
Copy link
Member

janvorli commented Sep 4, 2020

@BruceForstall I am already working on a fix.

@janvorli janvorli self-assigned this Sep 4, 2020
@janvorli janvorli added area-TypeSystem-coreclr and removed untriaged New issue has not been triaged by the area owner area-CrossGen/NGEN-coreclr labels Sep 4, 2020
@janvorli janvorli mentioned this issue Sep 4, 2020
Closed
@jashook jashook mentioned this issue Sep 4, 2020
Closed
@janvorli janvorli mentioned this issue Sep 4, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@janvorli janvorli

Labels
area-TypeSystem-coreclr blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix covariant returns validation janvorli/runtime
3 participants
@janvorli @BruceForstall @Dotnet-GitSync-Bot