-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues while building trying to use the Test Explorer in certain solutions #42121
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Do you know why the .NETFramework build of CompilerServices.Unsafe fails? Also do you have a binlog inside VS? |
I didn't build the library targeting net48 - Unsure if that's a requirement for using Test explorer? The only thing I did was
Yes, I actually do. Any places I could share it to? I'm trying to avoid posting it on GitHub directly as it seems to contain environment variables and things. |
We don't place any secrets in public build so no worries. Feel free to upload it here. No, there's no requirement on a root NETFramework build anymore :) |
But it's builds on my PC! 😊 I'm seeing some environment variables listed on the binlog so I was slightly concerned about it. But at the same time it doesn't look like I have anything sensitive on there so it's probably fine to put it here. TestUtilities_Debug_AnyCPU_Build_2020-09-11T22_28_01.5170401+09_00.binlog.txt - Remember to remove the last |
Oh sorry, got it. Thanks for the sharing the log. |
Tagging subscribers to this area: @ViktorHofer |
I nearly forgot about this, sorry! Reason for this break is because the CompilerServices.Unsafe project is missing from the solutions. I will submit a PR to fix this but I hope we can find a better way to solve this, probably with slnf. |
Trying to run some of the net5.0 tests with
Running |
Had to request a few features from slngen which we now use to generate solution files and keep them up-to-date which took a bit longer. Just submitted a PR that should fix the issues that you are seeing: #44703 |
This is all after a clean build via
./build.cmd clr+libs
. Currently on VS2019 16.8 P2.1. I've experienced this with./build.cmd -vs System.Diagnostics.EventLog
and./build.cmd -vs System.Globalization
but I remember seeing this with a few other solutions as well.VS tries to build
TestUtilities
when it's asked to run tests. It looks likeTestUtilities
targets NetCoreAppCurrent and .NET Framework 4.6.1 at the same time, and for some reason it tries to build the .NET Framework version too (and fails)? This is the error I get:Perhaps it should exclude the net461 unless
-framework net48
is specified when launching vs via command line? Not exactly sure what the issue is. I can provide the binlog if you need it.cc @ViktorHofer
The text was updated successfully, but these errors were encountered: