Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteCertificateValidationCallback is always called twice for TLS 1.3 on Windows #42823

Closed
wfurt opened this issue Sep 28, 2020 · 2 comments
Closed

Comments

@wfurt
Copy link
Member

wfurt commented Sep 28, 2020

This may not be big deal but it is inconsistent with other platforms and TLS versions. This is because the handshake uses "renegotiate" path even if there really is no renegotiation in TLS 1.3.

Framework has several tests where we assert that the callback is called exactly once per HTTP request so I noticed when porting TLS 1.3 changes. We can probably add special handling for TLS 1.3 (since there is no renegotiation) or we can skip the second invocation if remote certificate did not changed.

@ghost
Copy link

ghost commented Sep 28, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 28, 2020
@stephentoub stephentoub removed the untriaged New issue has not been triaged by the area owner label Sep 29, 2020
@wfurt
Copy link
Member Author

wfurt commented Oct 1, 2020

fixed by #42836

@wfurt wfurt closed this as completed Oct 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants