Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActivityTracker is mostly untrimmed even when event source is disabled #43635

Open
vitek-karas opened this issue Oct 20, 2020 · 4 comments
Open

ActivityTracker is mostly untrimmed even when event source is disabled #43635

vitek-karas opened this issue Oct 20, 2020 · 4 comments
Labels
area-System.Diagnostics.Tracing enhancement Product code improvement that does NOT require public API changes/additions size-reduction Issues impacting final app size primary for size sensitive workloads
Milestone
Future

Comments

@vitek-karas
Copy link
Member

ActivityTracker really only works if TplEventSource is enabled, so if all event sources are disabled via a feature switch EventSourceSupport there's really no need to keep its implementation around for anything.

Ideally we would refactor the code in it such that linker will be able to remove most of the implementation.
@vitek-karas vitek-karas added area-System.Diagnostics.Tracing linkable-framework Issues associated with delivering a linker friendly framework labels Oct 20, 2020
@vitek-karas vitek-karas added this to the 6.0.0 milestone Oct 20, 2020
@ghost
Copy link

ghost commented Oct 20, 2020

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Oct 20, 2020
@tarekgh tarekgh removed the untriaged New issue has not been triaged by the area owner label Oct 20, 2020
@noahfalk noahfalk added the enhancement Product code improvement that does NOT require public API changes/additions label Nov 10, 2020
@vitek-karas vitek-karas mentioned this issue Dec 7, 2020
Closed
@marek-safar marek-safar added size-reduction Issues impacting final app size primary for size sensitive workloads and removed linkable-framework Issues associated with delivering a linker friendly framework labels Dec 9, 2020
@LakshanF
Copy link
Member

In addition to the TplEventSource, AssemblyLoadContext and EventSource has references to this class

@eerhardt
Copy link
Member

@LakshanF - are you addressing this issue with the EventSource work you've been doing?

@LakshanF
Copy link
Member

I was not planning to - I took a quick look when I closed #43657 to see if its an easy fix but noted the additional references from AssemblyLoadCpntext, EventSource and left this issue separate from that work

@tommcdon tommcdon modified the milestones: 6.0.0, 7.0.0 Jun 16, 2021
@tommcdon tommcdon modified the milestones: 7.0.0, Future Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Diagnostics.Tracing enhancement Product code improvement that does NOT require public API changes/additions size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Milestone
Future
Development

No branches or pull requests
8 participants
@marek-safar @noahfalk @LakshanF @eerhardt @vitek-karas @tarekgh @tommcdon @Dotnet-GitSync-Bot