Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider annotating TaskCreationOptions.LongRunning as unsupported on browser #44865

Closed
marek-safar opened this issue Nov 18, 2020 · 4 comments
Closed

Consider annotating TaskCreationOptions.LongRunning as unsupported on browser #44865

marek-safar opened this issue Nov 18, 2020 · 4 comments
Labels
arch-wasm WebAssembly architecture area-System.Threading.Tasks
Milestone
7.0.0

Comments

@marek-safar
Copy link
Contributor

I don't have a strong opinion on this but we could consider annotating TaskCreationOptions.LongRunning and TaskContinuationOptions.LongRunning with UnsupportedOSPlatform("browser") attribute as we cannot handle them well.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Extensions-Options untriaged New issue has not been triaged by the area owner labels Nov 18, 2020
@ghost
Copy link

ghost commented Nov 18, 2020

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
Description:

I don't have a strong opinion on this but we could consider annotating TaskCreationOptions.LongRunning and TaskContinuationOptions.LongRunning with UnsupportedOSPlatform("browser") attribute as we cannot handle them well.
Author: marek-safar
Assignees: -
Labels:

area-Extensions-Options, untriaged
Milestone: -

@ghost
Copy link

ghost commented Nov 18, 2020

Tagging subscribers to this area: @tarekgh
See info in area-owners.md if you want to be subscribed.

Issue Details
Description:

I don't have a strong opinion on this but we could consider annotating TaskCreationOptions.LongRunning and TaskContinuationOptions.LongRunning with UnsupportedOSPlatform("browser") attribute as we cannot handle them well.
Author: marek-safar
Assignees: -
Labels:

area-Extensions-Options, area-System.Threading.Tasks, untriaged
Milestone: -

@marek-safar marek-safar added arch-wasm WebAssembly architecture and removed area-Extensions-Options labels Nov 18, 2020
@stephentoub
Copy link
Member

I think it'd be better to just make them nop. They already have a scheduler-specific meaning, as its the particular TaskScheduler being used that decides what to do if this is specified. I think it's reasonable on a platform that doesn't support new threads to say its just ignored. We've previously talked about supporting Thread.Start by just queuing a work item: if that was done, this would just naturally fall out.

@tarekgh tarekgh removed the untriaged New issue has not been triaged by the area owner label Nov 18, 2020
@tarekgh tarekgh added this to the 6.0.0 milestone Nov 18, 2020
@adamsitnik adamsitnik modified the milestones: 6.0.0, 7.0.0 Jul 28, 2021
@ilonatommy
Copy link
Member

Looks like a duplicate of #44544. @marek-safar are you fine with closing this one?

@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Threading.Tasks
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
6 participants
@marek-safar @stephentoub @adamsitnik @tarekgh @ilonatommy @Dotnet-GitSync-Bot