Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS-architecture RIDs #44931

Open
TheFanatr opened this issue Nov 19, 2020 · 13 comments
Open

macOS-architecture RIDs #44931

TheFanatr opened this issue Nov 19, 2020 · 13 comments
Labels
area-Meta design-discussion Ongoing discussion about design without consensus
Milestone

Comments

@TheFanatr
Copy link

By the time .NET 6 is released, it will have been more than five years since Apple renamed this operating system to "macOS". It's not called "OS X" any more. If it can be done correctly in TFMs, it can be done correctly in RIDs.

Originally posted by @warrenrumak in #43313 (comment)

This is in reference to the fact that RIDs for macOS are still osx-architecture (and seems like it will be osx-arm64 for Apple Silicon Macs); this should be fixed at this point before it becomes more set in stone.

@richlander replied to the above quoted comment, for the OP to file an issue, but they haven't and it's been a month, so here is mine.

Hope this gets done; if there's already an issue for this or it was already done, I didn't find it or notice, and someone can close.

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 19, 2020
@danmoseley danmoseley added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Meta labels Nov 19, 2020
@danmoseley
Copy link
Member

@terrajobst ?

@am11
Copy link
Member

am11 commented Nov 19, 2020

* NO MERGE *
but this is not a PR. 🙂

@aaronfranke
Copy link

@danmosemsft This issue is labeled * NO MERGE * but in #43313 it says "Support compilation targeting osx-arm64" and the box is checked. So this has already been merged, and should be fixed soon before it's too late.

@danmoseley
Copy link
Member

Thanks for pointing that out. As much as it's not ideal as is, I expect doing this would require cutting work in other places including NuGet. Could you say a little more about what you believe the relative priority of this should be and why?

Cc @terrajobst @richlander @wfurt @sdmaclea

@aaronfranke
Copy link

aaronfranke commented Jan 18, 2021

@danmosemsft The issue is that the longer we wait the bigger the potential breakage is. Since .NET 6 introduces new names (the mentioned inaccurate osx-arm64), the optimal strategy is to use the correct names from the start, and then the only breakages that have to be worried about are with the existing code. So I think this should be solved before .NET 6 is in preview; if .NET 6 follows a similar schedule to .NET 5, this means that this issue should be solved within the next few months.

EDIT: I suggest throwing this issue and #44120 on a milestone of some sort so it's not forgotten. I see that there is a "6.0.0" milestone, but maybe it should also go on some other milestone or tracker so it gets done within the next few months.

@danmoseley
Copy link
Member

Cc @ericstj @marek-safar

@sdmaclea
Copy link
Contributor

We will probably need to create macos & macos-* as an alias for osx & osx-*. I am not sure osx-arm64 makes the situation any worse as we would probably want to keep things symmetrical.

@TheFanatr
Copy link
Author

TheFanatr commented Jan 18, 2021

I think it's also somewhat useful to point out that not only is the operating system no longer called Mac OS X, macOS Big Sur is actually version 11 of the software, as opposed to 10.X for the multiple previous macOS releases, so it's incorrect on multiple levels due to "OS X" being version 10 by definition.

@marek-safar marek-safar added design-discussion Ongoing discussion about design without consensus and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) untriaged New issue has not been triaged by the area owner labels Jan 18, 2021
@marek-safar marek-safar added this to the 6.0.0 milestone Jan 18, 2021
@marek-safar
Copy link
Contributor

like it will be osx-arm64 for Apple Silicon Macs

yep, that's correct, and current setup

I agree there should be a way to alias OSX to macOS and vice-versa so developers can use both names on CLI and in their projects/NuGets. I don't think we should be pedantic and block osx-arm64 though.

@ericstj
Copy link
Member

ericstj commented May 20, 2021

Looks like this issue might be tracking the same thing as #44120

@krwq
Copy link
Member

krwq commented Jul 22, 2021

I assume this is now out of scope for 6.0?

@krwq krwq modified the milestones: 6.0.0, Future Jul 22, 2021
@ghost ghost added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Jul 22, 2021
@krwq
Copy link
Member

krwq commented Jul 22, 2021

Changed to future since the other issue is marked as Future

@krwq krwq removed the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta design-discussion Ongoing discussion about design without consensus
Projects
No open projects
Development

No branches or pull requests

9 participants