APIs that are marked as UnsupportedOSPlatform("browser") under System.ComponentModel.TypeConverter seems like all were false positives.

[buyaa-n]

I looked through the APIs that are marked as UnsupportedOSPlatform("browser") under System.ComponentModel.TypeConverter and to me it seems like all were false positives. I do see a common case where all are using Activator.CreateInstance or Type.GetConstructor which might have been the common pattern where the analyzer is flagging APIs are unsupported. These are the APIs that are marked as not supported:

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs

Line 121 in aebd598

public static object CreateWithContext(Type type, LicenseContext creationContext)

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs

Line 132 in aebd598

public static object CreateWithContext(Type type, LicenseContext creationContext, object[] args)

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/MaskedTextProvider.cs

Line 472 in aebd598

public object Clone()

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptionProvider.cs

Line 54 in aebd598

public virtual object CreateInstance(IServiceProvider provider, Type objectType, Type[] argTypes, object[] args)

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs

Line 433 in aebd598

public static object CreateInstance(IServiceProvider provider, Type objectType, Type[] argTypes, object[] args)

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/Security/Authentication/ExtendedProtection/ExtendedProtectionPolicyTypeConverter.cs

Line 21 in aebd598

public override object ConvertTo(ITypeDescriptorContext context, CultureInfo culture, object value, Type destinationType)

@steveisok @eerhardt do you agree that all these should be supported? That is the way it looks to me.

Originally posted by @safern in #43363 (comment)

[ghost]

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I looked through the APIs that are marked as UnsupportedOSPlatform("browser") under System.ComponentModel.TypeConverter and to me it seems like all were false positives. I do see a common case where all are using Activator.CreateInstance or Type.GetConstructor which might have been the common pattern where the analyzer is flagging APIs are unsupported. These are the APIs that are marked as not supported:

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs

Line 121 in aebd598

public static object CreateWithContext(Type type, LicenseContext creationContext)

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs

Line 132 in aebd598

public static object CreateWithContext(Type type, LicenseContext creationContext, object[] args)

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/MaskedTextProvider.cs

Line 472 in aebd598

public object Clone()

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptionProvider.cs

Line 54 in aebd598

public virtual object CreateInstance(IServiceProvider provider, Type objectType, Type[] argTypes, object[] args)

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs

Line 433 in aebd598

public static object CreateInstance(IServiceProvider provider, Type objectType, Type[] argTypes, object[] args)

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/Security/Authentication/ExtendedProtection/ExtendedProtectionPolicyTypeConverter.cs

Line 21 in aebd598

public override object ConvertTo(ITypeDescriptorContext context, CultureInfo culture, object value, Type destinationType)

@steveisok @eerhardt do you agree that all these should be supported? That is the way it looks to me.

Originally posted by @safern in #43363 (comment)

Author:	buyaa-n
Assignees:	-
Labels:	area-System.ComponentModel, untriaged
Milestone:	-

[buyaa-n]

It looks like those should all be supported. I'd like to understand why the tool gave a false positive because:

• Maybe we are missing something by just doing code inspection. And these APIs should really be flagged.
• Maybe there is a bug in the tool, and we marked a bunch of other APIs as unsupported, when really they should be.

Originally posted by @eerhardt in #43363 (comment)

[steveisok]

We used the tool to look for PNSE and NotSupportedException. Unfortunately, in the TypeConverter case, NSE is an expected throw and it was missed in review.

[buyaa-n]

I have removed the attributes from TypeDescriptor.CreateInstance, TypeDescriptionProvider.CreateInstance as it was referenced in my PR and causing warnings, remaining APIs ca be handled with this PR

[lewing]

Is there anything that needs to be done here? If so please reopen.