Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developers can control TLS establishment in SocketsHttpHandler via a callback #46849

Closed
1 task
karelz opened this issue Jan 12, 2021 · 6 comments
Closed
1 task
Assignees
Labels
area-System.Net.Http Bottom Up Work Not part of a theme, epic, or user story Cost:M Work that requires one engineer up to 2 weeks Priority:2 Work that is important, but not critical for the release Team:Libraries User Story A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@karelz
Copy link
Member

karelz commented Jan 12, 2021

@karelz karelz added area-System.Net.Http User Story A single user-facing feature. Can be grouped under an epic. Priority:2 Work that is important, but not critical for the release Cost:M Work that requires one engineer up to 2 weeks Bottom Up Work Not part of a theme, epic, or user story Team:Libraries labels Jan 12, 2021
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 12, 2021
@ghost
Copy link

ghost commented Jan 12, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: karelz
Assignees: -
Labels:

Bottom Up Work, Cost:M, Priority:2, Team:Libraries, User Story, area-System.Net.Http

Milestone: -

@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Jan 12, 2021
@karelz karelz added this to the 6.0.0 milestone Jan 12, 2021
@karelz karelz changed the title As developer, I want to pre-negotiate TLS in SocketsHttpHandler.ConnectCallback Developers can pre-negotiate TLS in SocketsHttpHandler.ConnectCallback Jan 12, 2021
@karelz karelz self-assigned this Jan 12, 2021
@geoffkizer
Copy link
Contributor

The title here is a bit confusing.

Do we want to enable a new callback to control TLS establishment? This seems reasonable and is pretty straightforward, something like SocketsHttpHandler.EstablishTlsCallback.

Or do we want to do something more complicated, that allows TLS "pre-negotiation" -- by which I assume we are pre-establishing TLS connections?

Or something else?

@karelz
Copy link
Member Author

karelz commented Jan 20, 2021

@geoffkizer it is user story for #42455 -- happy to change wording if you have better suggestion.
The goal is to allow developers to do custom TLS negotiation themselves for API like ConnectCallback

@geoffkizer geoffkizer changed the title Developers can pre-negotiate TLS in SocketsHttpHandler.ConnectCallback Developers can control TLS establishment in SocketsHttpHandler via a callback Jan 20, 2021
@geoffkizer
Copy link
Contributor

I edited the title, feel free to edit further.

@wfurt
Copy link
Member

wfurt commented Jan 21, 2021

Would we expect that the EstablishTlsCallback be given Stream and it would return SslStream @geoffkizer? And would that be on top of ConnectCallback or would it be mutually exclusive e.g. call one or the other based on the URI schema?

@karelz
Copy link
Member Author

karelz commented May 4, 2021

We decided to favor LLHTTP over this enhancement in 6.0. Closing this issue, the underlying real work is now in Future.

@karelz karelz closed this as completed May 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http Bottom Up Work Not part of a theme, epic, or user story Cost:M Work that requires one engineer up to 2 weeks Priority:2 Work that is important, but not critical for the release Team:Libraries User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Development

No branches or pull requests

4 participants