Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect building the repository without a source control provider available #47298

Open
ViktorHofer opened this issue Jan 21, 2021 · 1 comment
Open

Protect building the repository without a source control provider available #47298

ViktorHofer opened this issue Jan 21, 2021 · 1 comment
Labels
area-Infrastructure
Milestone
Future

Comments

@ViktorHofer
Copy link
Member

We had numerous incidents in the past where the repository wasn't buildable without the ".git" folder being available. This should be protected by nuking the .git folder away after fetching the repo (checkout) and passing in /p:DisableSourceLink (which is necessary as source link by default is only disabled locally, when not in CI).

More context in #47130.
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Jan 21, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 21, 2021
@ghost
Copy link

ghost commented Jan 21, 2021

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

We had numerous incidents in the past where the repository wasn't buildable without the ".git" folder being available. This should be protected by nuking the .git folder away after fetching the repo (checkout) and passing in /p:DisableSourceLink (which is necessary as source link by default is only disabled locally, when not in CI).

More context in #47130.

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure
Milestone: 6.0.0

@ViktorHofer ViktorHofer mentioned this issue Jan 25, 2021
Closed
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Feb 23, 2021
@ViktorHofer ViktorHofer modified the milestones: 6.0.0, Future Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Infrastructure
Projects
Runtime Infra
Status: No status
Milestone
Future
Development

No branches or pull requests
1 participant
@ViktorHofer