Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGO: seeing nonsensical counts and corrupted type handles #47930

Closed
AndyAyersMS opened this issue Feb 5, 2021 · 3 comments
Closed

PGO: seeing nonsensical counts and corrupted type handles #47930

AndyAyersMS opened this issue Feb 5, 2021 · 3 comments
Assignees
Milestone

Comments

@AndyAyersMS
Copy link
Member

See notes: #47790 (comment)

Suspect the copying done by getPgoInstrumentationResultsInstance is still off.

cc @davidwrighton

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 5, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@AndyAyersMS
Copy link
Member Author

This fixes things for me (at least counts look good) ... not sure if it's the right fix overall:

-        volatile size_t*pSrc = (volatile size_t*)found->header.GetData();
+        volatile size_t*pSrc = (volatile size_t*)(found->header.GetData() + found->header.countsOffset);

@AndyAyersMS
Copy link
Member Author

Added the above fix to #47959.

@AndyAyersMS AndyAyersMS self-assigned this Feb 8, 2021
@AndyAyersMS AndyAyersMS removed the untriaged New issue has not been triaged by the area owner label Feb 8, 2021
@AndyAyersMS AndyAyersMS added this to the 6.0.0 milestone Feb 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

1 participant