Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS-arm64 native crossgen2 build missing #48001

Closed
sdmaclea opened this issue Feb 8, 2021 · 3 comments · Fixed by #52322
Closed

MacOS-arm64 native crossgen2 build missing #48001

sdmaclea opened this issue Feb 8, 2021 · 3 comments · Fixed by #52322
Assignees
@sdmaclea
Labels
arch-arm64 area-crossgen2-coreclr blocked Issue/PR is blocked on something - see comments disabled-test The test is disabled in source code against the issue os-macos-bigsur (macOS11)
Milestone
6.0.0

Comments

@sdmaclea
Copy link
Contributor

sdmaclea commented Feb 8, 2021

When building coreclr on Apple Silicon crossgen2 is created for x86_x64 instead of arm64. The native one is missing.
@sdmaclea sdmaclea added this to the 6.0.0 milestone Feb 8, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 8, 2021
@mangod9
Copy link
Member

mangod9 commented Feb 11, 2021

cc @AntonLapounov

@sdmaclea sdmaclea added the disabled-test The test is disabled in source code against the issue label Apr 7, 2021
@sdmaclea
Copy link
Contributor Author

sdmaclea commented Apr 7, 2021

These tests are disabled for this issue.

runtime/src/tests/issues.targets

Lines 739 to 748 in c320071

<!-- Crossgen2 issues -->
<ExcludeList Include="$(XunitTestBinBase)/readytorun/crossgen2/crossgen2smoke/*">
<Issue>https://github.com/dotnet/runtime/issues/48001</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/readytorun/multifolder/multifolder/*">
<Issue>https://github.com/dotnet/runtime/issues/48001</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/readytorun/r2rdump/FrameworkTests/R2RDumpTests/*">
<Issue>https://github.com/dotnet/runtime/issues/48001</Issue>
</ExcludeList>

@trylek trylek removed the untriaged New issue has not been triaged by the area owner label Apr 11, 2021
@Bo98 Bo98 mentioned this issue Apr 14, 2021
Merged
@mangod9
Copy link
Member

mangod9 commented May 5, 2021

Believe this should be fixed.

@sdmaclea sdmaclea mentioned this issue May 5, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 5, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 5, 2021
@sdmaclea sdmaclea self-assigned this May 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sdmaclea sdmaclea

Labels
arch-arm64 area-crossgen2-coreclr blocked Issue/PR is blocked on something - see comments disabled-test The test is disabled in source code against the issue os-macos-bigsur (macOS11)
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Reenable48001 sdmaclea/runtime
4 participants
@ViktorHofer @trylek @sdmaclea @mangod9