Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ILLink warning analysis for OOB libraries #48488

Closed
eerhardt opened this issue Feb 18, 2021 · 2 comments · Fixed by #52272
Closed

Enable ILLink warning analysis for OOB libraries #48488

eerhardt opened this issue Feb 18, 2021 · 2 comments · Fixed by #52272
Assignees
@joperezr
Labels
area-Infrastructure-libraries linkable-framework Issues associated with delivering a linker friendly framework
Milestone
6.0.0

Comments

@eerhardt
Copy link
Member

In #38033 we enabled ILLink warning analysis for assemblies that are in the NETCoreApp shared fx / runtimepack.

With #48428 we are marking all libraries built in dotnet/runtime as "trimmable". We should enable ILLink warning analysis for these libraries as well. And then once we are finished resolving the warnings in the libraries in the runtimepack (#45623), we will start working on the rest of the libraries as well.

cc @marek-safar @joperezr @sbomer
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Feb 18, 2021
@ghost
Copy link

ghost commented Feb 18, 2021

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

In #38033 we enabled ILLink warning analysis for assemblies that are in the NETCoreApp shared fx / runtimepack.

With #48428 we are marking all libraries built in dotnet/runtime as "trimmable". We should enable ILLink warning analysis for these libraries as well. And then once we are finished resolving the warnings in the libraries in the runtimepack (#45623), we will start working on the rest of the libraries as well.

cc @marek-safar @joperezr @sbomer

Author: eerhardt
Assignees: -
Labels:

area-Infrastructure-libraries, untriaged
Milestone: -

@eerhardt eerhardt added the linkable-framework Issues associated with delivering a linker friendly framework label Feb 18, 2021
@ghost
Copy link

ghost commented Feb 18, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

In #38033 we enabled ILLink warning analysis for assemblies that are in the NETCoreApp shared fx / runtimepack.

With #48428 we are marking all libraries built in dotnet/runtime as "trimmable". We should enable ILLink warning analysis for these libraries as well. And then once we are finished resolving the warnings in the libraries in the runtimepack (#45623), we will start working on the rest of the libraries as well.

cc @marek-safar @joperezr @sbomer

Author: eerhardt
Assignees: -
Labels:

area-Infrastructure-libraries, linkable-framework, untriaged
Milestone: -

@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Feb 23, 2021
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Feb 23, 2021
@eerhardt eerhardt mentioned this issue Mar 3, 2021
Closed
@eerhardt eerhardt mentioned this issue Mar 19, 2021
Merged
@joperezr joperezr self-assigned this Apr 30, 2021
@joperezr joperezr mentioned this issue Apr 30, 2021
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 30, 2021
@joperezr joperezr mentioned this issue May 4, 2021
Merged
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joperezr joperezr

Labels
area-Infrastructure-libraries linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
6.0.0
3 participants
@ViktorHofer @eerhardt @joperezr