Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crossgen2] Lazy string optimization #48580

Closed
jkotas opened this issue Feb 22, 2021 · 2 comments
Closed

[crossgen2] Lazy string optimization #48580

jkotas opened this issue Feb 22, 2021 · 2 comments

Comments

@jkotas
Copy link
Member

jkotas commented Feb 22, 2021

crossgen1 avoided emitting string fixups for strings used on exception throwing paths. crossgen2 is missing this optimization.

Note that this optimization produces a bit larger code, but saves time during startup by avoid string constant allocations.

See #47183 for more context.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 22, 2021
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Mar 16, 2021
@mangod9 mangod9 added this to the 6.0.0 milestone Mar 16, 2021
@davidwrighton
Copy link
Member

This feature was cut from 6.0.0 due to lack of evidence on improvements to startup/working set. We should perform the analysis of the value of this optimization in 7.0

@davidwrighton davidwrighton modified the milestones: 6.0.0, 7.0.0 Jul 19, 2021
@davidwrighton davidwrighton modified the milestones: 7.0.0, 8.0.0 Jul 6, 2022
@trylek trylek mentioned this issue May 3, 2023
46 tasks
@davidwrighton
Copy link
Member

This year I spent significant time investigating startup performance, and the impact of realizing string literals was never even visible in the startup measurements at all. I'm going to close this as not interesting to invest in, especially given the data that adding them will increase file size.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants